third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2019583002: Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers.

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2019583002: Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer-expected.txt ('K') | « third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-content-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.

5 * Copyright (C) 2010 Google Inc. All rights reserved.	5 * Copyright (C) 2010 Google Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 274 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
285 // The query rect is given in local coordinate system.	285 // The query rect is given in local coordinate system.

286 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; }	286 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; }

287	287

288 void invalidateTreeIfNeeded(const PaintInvalidationState&) override;	288 void invalidateTreeIfNeeded(const PaintInvalidationState&) override;

289	289

290 // Indicate that the contents of this layoutObject need to be repainted.	290 // Indicate that the contents of this layoutObject need to be repainted.

291 // This only has an effect if compositing is being used.	291 // This only has an effect if compositing is being used.

292 // The rect is in the physical coordinate space of this layout object.	292 // The rect is in the physical coordinate space of this layout object.

293 void setBackingNeedsPaintInvalidationInRect(const LayoutRect&, PaintInvalida tionReason, const LayoutObject&) const;	293 void setBackingNeedsPaintInvalidationInRect(const LayoutRect&, PaintInvalida tionReason, const LayoutObject&) const;

294	294

295 void invalidateDisplayItemClientOnBacking(const DisplayItemClient&, PaintInv alidationReason) const;	295 // The third parameter should be equal to the DisplayItemClient if it happen s to be a LayoutObjert subclass. It is only used
	wkorman 2016/05/31 18:34:15 LayoutObjert -> LayoutObject LayoutObjert -> LayoutObject chrishtr 2016/05/31 18:51:54 Done. Show quoted text On 2016/05/31 at 18:34:15, wkorman wrote: > LayoutObjert -> LayoutObject Done.
	296 // for debugging.

	297 void invalidateDisplayItemClientOnBacking(const DisplayItemClient&, PaintInv alidationReason, const LayoutObject* = nullptr) const;

296	298

297 // http://www.w3.org/TR/css3-background/#body-background	299 // http://www.w3.org/TR/css3-background/#body-background

298 // <html> root element with no background steals background from its first < body> child.	300 // <html> root element with no background steals background from its first < body> child.

299 // The used background for such body element should be the initial value. (i .e. transparent)	301 // The used background for such body element should be the initial value. (i .e. transparent)

300 bool backgroundStolenForBeingBody(const ComputedStyle* rootElementStyle = nu llptr) const;	302 bool backgroundStolenForBeingBody(const ComputedStyle* rootElementStyle = nu llptr) const;

301	303

302 protected:	304 protected:

303 void willBeDestroyed() override;	305 void willBeDestroyed() override;

304	306

305 LayoutPoint adjustedPositionRelativeToOffsetParent(const LayoutPoint&) const ;	307 LayoutPoint adjustedPositionRelativeToOffsetParent(const LayoutPoint&) const ;

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
381 OwnPtr<PaintLayer> m_layer;	383 OwnPtr<PaintLayer> m_layer;

382	384

383 OwnPtr<LayoutBoxModelObjectRareData> m_rareData;	385 OwnPtr<LayoutBoxModelObjectRareData> m_rareData;

384 };	386 };

385	387

386 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());	388 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());

387	389

388 } // namespace blink	390 } // namespace blink

389	391

390 #endif // LayoutBoxModelObject_h	392 #endif // LayoutBoxModelObject_h

OLD	NEW