chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc - Issue 2019533002: [Android] Fix crash when closing tab during infobar cancellation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc

Issue 2019533002: [Android] Fix crash when closing tab during infobar cancellation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test on mobile Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc

diff --git a/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc b/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc

index 6d81f9cc0447645b1ad863e80187d8f5443265f5..36963bb7bc57c2e7f577a3748972738b6aa70e07 100644

--- a/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc

+++ b/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc

@@ -114,15 +114,13 @@ SimpleConfirmInfoBarDelegate::GetButtonLabel(InfoBarButton button) const {

}

bool SimpleConfirmInfoBarDelegate::Accept() {

- Java_SimpleConfirmInfoBarBuilder_onInfoBarButtonClicked(

+ return !Java_SimpleConfirmInfoBarBuilder_onInfoBarButtonClicked(

base::android::AttachCurrentThread(), java_listener_.obj(), true);

- return true;

}

bool SimpleConfirmInfoBarDelegate::Cancel() {

- Java_SimpleConfirmInfoBarBuilder_onInfoBarButtonClicked(

+ return !Java_SimpleConfirmInfoBarBuilder_onInfoBarButtonClicked(

base::android::AttachCurrentThread(), java_listener_.obj(), false);

- return true;

}

} // anonymous namespace