chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java - Issue 2019533002: [Android] Fix crash when closing tab during infobar cancellation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

Issue 2019533002: [Android] Fix crash when closing tab during infobar cancellation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test on mobile Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java ('k') | chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

index 21743059c293ceec9606e8e6aea1ed129d6da7c4..955d06b47dc7cbf04d65f9d6aba7375ae84bb5ab 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java

@@ -46,12 +46,13 @@ public class InfoBarContainerTest extends ChromeActivityTestCaseBase<ChromeActiv

}

@Override

- public void onInfoBarButtonClicked(boolean isPrimary) {

+ public boolean onInfoBarButtonClicked(boolean isPrimary) {

if (isPrimary) {

primaryButtonCallback.notifyCalled();

} else {

secondaryButtonCallback.notifyCalled();

}

+ return false;

}