Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 2019513004: Validate bound buffer for draw calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use cache Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
index bcf2d1b2ce804ec894bf4b07cdb4252f1025cfad..57402a394f2f403ec353006dbb5cf2ed3fdbfe0e 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
@@ -33,6 +33,10 @@ public:
WebGLBuffer* getArrayBufferForAttrib(size_t);
void setArrayBufferForAttrib(GLuint, WebGLBuffer*);
+ void setAttribEnabled(GLuint, bool);
+ bool getAttribEnabled(GLuint) const;
+ bool isAllEnabledAttribBufferBound() const { return m_isAllEnabledAttribBufferBound; }
+ void updateAttribBufferBoundStatus();
Ken Russell (switch to Gerrit) 2016/06/07 04:25:11 updateAttribBufferBoundStatus should be private, o
qiankun 2016/06/07 05:01:35 Done.
void unbindBuffer(WebGLBuffer*);
ScopedPersistent<v8::Array>* getPersistentCache();
@@ -54,6 +58,8 @@ private:
bool m_destructionInProgress;
Member<WebGLBuffer> m_boundElementArrayBuffer;
HeapVector<Member<WebGLBuffer>> m_arrayBufferList;
+ Vector<bool> m_attribEnabled;
+ bool m_isAllEnabledAttribBufferBound;
// For preserving the wrappers of WebGLBuffer objects latched in
// via vertexAttribPointer calls.

Powered by Google App Engine
This is Rietveld 408576698