chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc - Issue 2019413002: Remove KeyboardDevice class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

Issue 2019413002: Remove KeyboardDevice class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/events/event_rewriter.cc ('K') | « chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc ('k') | ui/events/devices/BUILD.gn » ('j') | ui/events/devices/x11/device_data_manager_x11.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc b/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

index ba65d6e641a76aae36fe10e220cc98507a004502..8d7c3d69324d47f383c720d85fcc5fd6dff2054d 100644

--- a/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

@@ -13,12 +13,11 @@

#include "chromeos/chromeos_switches.h"

#include "content/public/browser/web_ui.h"

#include "ui/events/devices/device_data_manager.h"

-#include "ui/events/devices/keyboard_device.h"

namespace {

bool HasExternalKeyboard() {

- for (const ui::KeyboardDevice& keyboard :

+ for (const ui::InputDevice& keyboard :

ui::DeviceDataManager::GetInstance()->keyboard_devices()) {

if (keyboard.type == ui::InputDeviceType::INPUT_DEVICE_EXTERNAL)

return true;