chrome/browser/chromeos/events/event_rewriter.cc - Issue 2019413002: Remove KeyboardDevice class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 2019413002: Remove KeyboardDevice class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/events/event_rewriter.cc

diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc

index f2ef9b2e0f91248a5177c774f0f611013a68dc4d..284f0ac529088ecf2f14be1d6042b508e3914c47 100644

--- a/chrome/browser/chromeos/events/event_rewriter.cc

+++ b/chrome/browser/chromeos/events/event_rewriter.cc

@@ -1142,7 +1142,7 @@ EventRewriter::DeviceType EventRewriter::KeyboardDeviceAddedInternal(

EventRewriter::DeviceType EventRewriter::KeyboardDeviceAdded(int device_id) {

if (!ui::DeviceDataManager::HasInstance())

return kDeviceUnknown;

- const std::vector<ui::KeyboardDevice>& keyboards =

+ const std::vector<ui::InputDevice>& keyboards =

sky 2016/05/31 18:13:45 keyboard_devices? or perhaps just move into for lo

kylechar 2016/05/31 19:31:12 Done.

ui::DeviceDataManager::GetInstance()->keyboard_devices();

for (const auto& keyboard : keyboards) {

if (keyboard.id == device_id) {