Remove KeyboardDevice class.

Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=601981
Committed: https://crrev.com/65cb32e4bac337419a78cc63fcd795567b130385
Cr-Commit-Position: refs/heads/master@{#396950}

[kylechar, 2016-05-30 16:19:46]

Description was changed from

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs for to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=none
==========

to

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=none
==========

[kylechar, 2016-05-30 19:48:14]

Description was changed from

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=none
==========

to

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=601981
==========

[kylechar, 2016-05-30 19:48:21]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-30 19:48:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019413002/1

[commit-bot: I haz the power, 2016-05-30 21:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 21:09:46]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-05-30 21:15:53]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-05-31 18:13:45]

LGTM

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
File ash/virtual_keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:85: std::vector<ui::InputDevice>
keyboards;
input_devices or maybe keyboard_devices?

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:163: std::vector<ui::InputDevice>
keyboards;
keyboard_devices?

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:195: std::vector<ui::InputDevice>
keyboards;
keyboard_devices?

https://codereview.chromium.org/2019413002/diff/1/chrome/browser/chromeos/eve...
File chrome/browser/chromeos/events/event_rewriter.cc (right):

https://codereview.chromium.org/2019413002/diff/1/chrome/browser/chromeos/eve...
chrome/browser/chromeos/events/event_rewriter.cc:1145: const
std::vector<ui::InputDevice>& keyboards =
keyboard_devices? or perhaps just move into for loop, eg:
for (const auto& keyboard : ui::DeviceData...

https://codereview.chromium.org/2019413002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.h (right):

https://codereview.chromium.org/2019413002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.h:386: std::map<int,
ui::InputDevice> blocked_keyboards_;
blocked_keyboard_devices?

[kylechar, 2016-05-31 19:31:12]

Change the variable names as requested. Thanks for the review!

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
File ash/virtual_keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:85: std::vector<ui::InputDevice>
keyboards;
On 2016/05/31 18:13:45, sky wrote:
> input_devices or maybe keyboard_devices?

Done.

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:163: std::vector<ui::InputDevice>
keyboards;
On 2016/05/31 18:13:45, sky wrote:
> keyboard_devices?

Done.

https://codereview.chromium.org/2019413002/diff/1/ash/virtual_keyboard_contro...
ash/virtual_keyboard_controller_unittest.cc:195: std::vector<ui::InputDevice>
keyboards;
On 2016/05/31 18:13:45, sky wrote:
> keyboard_devices?

Done.

https://codereview.chromium.org/2019413002/diff/1/chrome/browser/chromeos/eve...
File chrome/browser/chromeos/events/event_rewriter.cc (right):

https://codereview.chromium.org/2019413002/diff/1/chrome/browser/chromeos/eve...
chrome/browser/chromeos/events/event_rewriter.cc:1145: const
std::vector<ui::InputDevice>& keyboards =
On 2016/05/31 18:13:45, sky wrote:
> keyboard_devices? or perhaps just move into for loop, eg:
> for (const auto& keyboard : ui::DeviceData...

Done.

https://codereview.chromium.org/2019413002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.h (right):

https://codereview.chromium.org/2019413002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.h:386: std::map<int,
ui::InputDevice> blocked_keyboards_;
On 2016/05/31 18:13:45, sky wrote:
> blocked_keyboard_devices?

Done.

[kylechar, 2016-05-31 19:32:00]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-05-31 19:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2019413002/#ps20001
(title: "Fixes for comments.")

[commit-bot: I haz the power, 2016-05-31 19:33:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019413002/20001

[commit-bot: I haz the power, 2016-05-31 22:19:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 22:21:19]

Description was changed from

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=601981
==========

to

==========
Remove KeyboardDevice class.

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=601981

Committed: https://crrev.com/65cb32e4bac337419a78cc63fcd795567b130385
Cr-Commit-Position: refs/heads/master@{#396950}
==========

[commit-bot: I haz the power, 2016-05-31 22:21:21]

Patchset 2 (id:??) landed as
https://crrev.com/65cb32e4bac337419a78cc63fcd795567b130385
Cr-Commit-Position: refs/heads/master@{#396950}