Add new InputDeviceManager interface.

Add new InputDeviceManager interface.

This interface contains the methods from DeviceDataManager that we want
to expose in multiple processes for mash.

A different implementation of the interface will be required to mirror
input device state. This will come in a follow up CL.

InputDeviceManager holds a non-owning static pointer to an
implementation. This allows client code to be agnostic to which
implementation they are using.

Update client code that uses DeviceDataManager to get information about
input-devices to use InputDeviceManager instead. This should have
identical functionality in cash and be suitable for use with mash.

There is client code where DeviceDataManager is used for information
about touch transforms or where DeviceDataManager state is manipulated
in tests. These cases are beyond the scope of InputDeviceManager and
client code was not updated here.

BUG=601981
Committed: https://crrev.com/e223f03206a1f3a34141f36c39ad6f77557bea0d
Cr-Commit-Position: refs/heads/master@{#397707}

[kylechar, 2016-05-31 20:54:34]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-05-31 20:54:35]

sadrul@ for ui/* and general structure. It's missing the GYP file, I will add
that in tomorrow after the CL this depends on is submitted and I've rebased.

[sadrul, 2016-06-02 15:04:39]

lgtm

https://codereview.chromium.org/2028593004/diff/1/ui/events/devices/input_dev...
File ui/events/devices/input_device_manager.h (right):

https://codereview.chromium.org/2028593004/diff/1/ui/events/devices/input_dev...
ui/events/devices/input_device_manager.h:33: virtual bool
device_lists_complete() const = 0;
I believe virtual methods are to be NamedLikeThis()

I would call the last one IsDeviceListsComplete()

[kylechar, 2016-06-02 15:23:49]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2016-06-02 15:23:50]

I've updated the names of the virtual methods. Adding sky@ for ash/* and
chrome/*.

https://codereview.chromium.org/2028593004/diff/1/ui/events/devices/input_dev...
File ui/events/devices/input_device_manager.h (right):

https://codereview.chromium.org/2028593004/diff/1/ui/events/devices/input_dev...
ui/events/devices/input_device_manager.h:33: virtual bool
device_lists_complete() const = 0;
On 2016/06/02 15:04:39, sadrul wrote:
> I believe virtual methods are to be NamedLikeThis()
> 
> I would call the last one IsDeviceListsComplete()

Done.

[sky, 2016-06-02 17:56:28]

LGTM

[kylechar, 2016-06-02 17:58:21]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-02 17:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2028593004/#ps20001
(title: "Rebase/naming/GYP.")

[commit-bot: I haz the power, 2016-06-02 17:58:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028593004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028593004/20001

[commit-bot: I haz the power, 2016-06-02 19:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 19:29:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-06-02 20:59:37]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-02 20:59:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2028593004/#ps40001
(title: "Fix windows compile error.")

[commit-bot: I haz the power, 2016-06-02 21:02:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028593004/40001

[commit-bot: I haz the power, 2016-06-03 00:14:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 00:14:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-06-03 14:20:41]

Looks like the last CQ failure was just a flake, will try it again.

[kylechar, 2016-06-03 14:20:52]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-06-03 14:21:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028593004/40001

[commit-bot: I haz the power, 2016-06-03 15:03:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 15:05:48]

Description was changed from

==========
Add new InputDeviceManager interface.

This interface contains the methods from DeviceDataManager that we want
to expose in multiple processes for mash.

A different implementation of the interface will be required to mirror
input device state. This will come in a follow up CL.

InputDeviceManager holds a non-owning static pointer to an
implementation. This allows client code to be agnostic to which
implementation they are using.

Update client code that uses DeviceDataManager to get information about
input-devices to use InputDeviceManager instead. This should have
identical functionality in cash and be suitable for use with mash.

There is client code where DeviceDataManager is used for information
about touch transforms or where DeviceDataManager state is manipulated
in tests. These cases are beyond the scope of InputDeviceManager and
client code was not updated here.

BUG=601981
==========

to

==========
Add new InputDeviceManager interface.

This interface contains the methods from DeviceDataManager that we want
to expose in multiple processes for mash.

A different implementation of the interface will be required to mirror
input device state. This will come in a follow up CL.

InputDeviceManager holds a non-owning static pointer to an
implementation. This allows client code to be agnostic to which
implementation they are using.

Update client code that uses DeviceDataManager to get information about
input-devices to use InputDeviceManager instead. This should have
identical functionality in cash and be suitable for use with mash.

There is client code where DeviceDataManager is used for information
about touch transforms or where DeviceDataManager state is manipulated
in tests. These cases are beyond the scope of InputDeviceManager and
client code was not updated here.

BUG=601981

Committed: https://crrev.com/e223f03206a1f3a34141f36c39ad6f77557bea0d
Cr-Commit-Position: refs/heads/master@{#397707}
==========

[commit-bot: I haz the power, 2016-06-03 15:05:50]

Patchset 3 (id:??) landed as
https://crrev.com/e223f03206a1f3a34141f36c39ad6f77557bea0d
Cr-Commit-Position: refs/heads/master@{#397707}