Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2019383003: Remove DWrite locks (Closed)

Created:
4 years, 6 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
kouhei (in TOK)
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove DWrite locks BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2019383003

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -83 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 1 11 chunks +48 lines, -83 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2019383003/20001
4 years, 5 months ago (2016-06-27 08:08:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 08:25:32 UTC) #5
kouhei (in TOK)
Given that this is a controversial change, we want to be sure that performance benefit ...
4 years, 5 months ago (2016-06-28 04:39:30 UTC) #8
tzik
On 2016/06/28 04:39:30, kouhei wrote: > Given that this is a controversial change, we want ...
4 years, 5 months ago (2016-06-28 12:28:35 UTC) #9
tzik
4 years, 5 months ago (2016-06-29 05:44:34 UTC) #10
On 2016/06/28 12:28:35, tzik wrote:
> On 2016/06/28 04:39:30, kouhei wrote:
> > Given that this is a controversial change, we want to be sure that
performance
> > benefit is worth it.
> > Would you collect performance numbers on windows machine?
> > e.g) TTFMP was 1000ms, raster took 100ms, applying CL made raster 50ms -> X%
> > impact in user perceived page load latency
> 
> Sure. On a text-heavy English site [1], the improvement was 9ms (1.5%,
relative
> to TTFCP). And on a text-heavy Japanese site [2], it was 70ms (9%, relative to
> TTFCP).
> On [1], TTFCP was 593ms. The rasterization after TTFCP took 18ms without this
> CL, and took 9.3ms with this CL.
> On [2], TTFCP was 759ms. The rasterization took 78.3ms without this CL, and
took
> 8.0ms with this CL.

Oops, I forgot to add the URLs.
[1]: https://en-us.facebook.com/terms
[2]: https://ja-jp.facebook.com/terms

Powered by Google App Engine
This is Rietveld 408576698