Remove DWrite locks

src/ports/SkScalerContext_win_dw.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkTypes.h"
 #if defined(SK_BUILD_FOR_WIN32)
 
 #undef GetGlyphIndices
 
 #include "SkDraw.h"
 #include "SkDWrite.h"
 #include "SkDWriteGeometrySink.h"
 #include "SkEndian.h"
 #include "SkGlyph.h"
 #include "SkHRESULT.h"
 #include "SkMaskGamma.h"
 #include "SkMatrix22.h"
-#include "SkMutex.h"
 #include "SkOTTable_EBLC.h"
 #include "SkOTTable_EBSC.h"
 #include "SkOTTable_gasp.h"
 #include "SkOTTable_maxp.h"
 #include "SkPath.h"
 #include "SkRasterClip.h"
 #include "SkScalerContext.h"
 #include "SkScalerContext_win_dw.h"
-#include "SkSharedMutex.h"
 #include "SkTScopedComPtr.h"
 #include "SkTypeface_win_dw.h"
 
 #include <dwrite.h>
 #if SK_HAS_DWRITE_1_H
 #  include <dwrite_1.h>
 #endif
 
-/* Note:
- * In versions 8 and 8.1 of Windows, some calls in DWrite are not thread safe.
- * The DWriteFactoryMutex protects the calls that are problematic.
- */
-static SkSharedMutex DWriteFactoryMutex;
-
-typedef SkAutoSharedMutexShared Shared;
-
 static bool isLCD(const SkScalerContext::Rec& rec) {
     return SkMask::kLCD16_Format == rec.fMaskFormat;
 }
 
 static bool is_hinted_without_gasp(DWriteFontTypeface* typeface) {
-    SkAutoExclusive l(DWriteFactoryMutex);
     AutoTDWriteTable<SkOTTableMaximumProfile> maxp(typeface->fDWriteFontFace.get());
     if (!maxp.fExists) {
         return false;
     }
     if (maxp.fSize < sizeof(SkOTTableMaximumProfile::Version::TT)) {
         return false;
     }
     if (maxp->version.version != SkOTTableMaximumProfile::Version::TT::VERSION) {
         return false;
     }
@@ skipping 49 matching lines @@
         {
             range->min = minPPEM + 1;
             range->max = maxPPEM;
             return;
         }
         minPPEM = maxPPEM;
     }
 }
 
 static bool has_bitmap_strike(DWriteFontTypeface* typeface, PPEMRange range) {
-    SkAutoExclusive l(DWriteFactoryMutex);
     {
         AutoTDWriteTable<SkOTTableEmbeddedBitmapLocation> eblc(typeface->fDWriteFontFace.get());
         if (!eblc.fExists) {
             return false;
         }
         if (eblc.fSize < sizeof(SkOTTableEmbeddedBitmapLocation)) {
             return false;
         }
         if (eblc->version != SkOTTableEmbeddedBitmapLocation::version_initial) {
             return false;
@@ skipping 222 matching lines @@
 
     glyph->fAdvanceX = 0;
     glyph->fAdvanceY = 0;
 
     uint16_t glyphId = glyph->getGlyphID();
     DWRITE_GLYPH_METRICS gm;
 
     if (DWRITE_MEASURING_MODE_GDI_CLASSIC == fMeasuringMode ||
         DWRITE_MEASURING_MODE_GDI_NATURAL == fMeasuringMode)
     {
-        SkAutoExclusive l(DWriteFactoryMutex);
         HRVM(fTypeface->fDWriteFontFace->GetGdiCompatibleGlyphMetrics(
                  fTextSizeMeasure,
                  1.0f, // pixelsPerDip
                  &fGsA,
                  DWRITE_MEASURING_MODE_GDI_NATURAL == fMeasuringMode,
                  &glyphId, 1,
                  &gm),
              "Could not get gdi compatible glyph metrics.");
     } else {
-        SkAutoExclusive l(DWriteFactoryMutex);
         HRVM(fTypeface->fDWriteFontFace->GetDesignGlyphMetrics(&glyphId, 1, &gm),
              "Could not get design metrics.");
     }
 
     DWRITE_FONT_METRICS dwfm;
-    {
-        Shared l(DWriteFactoryMutex);
-        fTypeface->fDWriteFontFace->GetMetrics(&dwfm);
-    }
+    fTypeface->fDWriteFontFace->GetMetrics(&dwfm);
     SkScalar advanceX = SkScalarMulDiv(fTextSizeMeasure,
                                        SkIntToScalar(gm.advanceWidth),
                                        SkIntToScalar(dwfm.designUnitsPerEm));
 
     SkVector vecs[1] = { { advanceX, 0 } };
     if (DWRITE_MEASURING_MODE_GDI_CLASSIC == fMeasuringMode ||
         DWRITE_MEASURING_MODE_GDI_NATURAL == fMeasuringMode)
     {
         // DirectWrite produced 'compatible' metrics, but while close,
         // the end result is not always an integer as it would be with GDI.
@@ skipping 28 matching lines @@
     run.glyphCount = 1;
     run.glyphAdvances = &advance;
     run.fontFace = fTypeface->fDWriteFontFace.get();
     run.fontEmSize = SkScalarToFloat(fTextSizeRender);
     run.bidiLevel = 0;
     run.glyphIndices = &glyphId;
     run.isSideways = FALSE;
     run.glyphOffsets = &offset;
 
     SkTScopedComPtr<IDWriteGlyphRunAnalysis> glyphRunAnalysis;
-    {
-        SkAutoExclusive l(DWriteFactoryMutex);
-        HRM(fTypeface->fFactory->CreateGlyphRunAnalysis(
-            &run,
-            1.0f, // pixelsPerDip,
-            &fXform,
-            renderingMode,
-            fMeasuringMode,
-            0.0f, // baselineOriginX,
-            0.0f, // baselineOriginY,
-            &glyphRunAnalysis),
-            "Could not create glyph run analysis.");
-    }
-    {
-        Shared l(DWriteFactoryMutex);
-        HRM(glyphRunAnalysis->GetAlphaTextureBounds(textureType, bbox),
-            "Could not get texture bounds.");
-    }
+    HRM(fTypeface->fFactory->CreateGlyphRunAnalysis(
+        &run,
+        1.0f, // pixelsPerDip,
+        &fXform,
+        renderingMode,
+        fMeasuringMode,
+        0.0f, // baselineOriginX,
+        0.0f, // baselineOriginY,
+        &glyphRunAnalysis),
+        "Could not create glyph run analysis.");
+    HRM(glyphRunAnalysis->GetAlphaTextureBounds(textureType, bbox),
+        "Could not get texture bounds.");
     return S_OK;
 }
 
 /** GetAlphaTextureBounds succeeds but sometimes returns empty bounds like
  *  { 0x80000000, 0x80000000, 0x80000000, 0x80000000 }
  *  for small, but not quite zero, sized glyphs.
  *  Only set as non-empty if the returned bounds are non-empty.
  */
 static bool glyph_check_and_set_bounds(SkGlyph* glyph, const RECT& bbox) {
     if (bbox.left >= bbox.right || bbox.top >= bbox.bottom) {
@@ skipping 267 matching lines @@
     run.glyphAdvances = &advance;
     run.fontFace = fTypeface->fDWriteFontFace.get();
     run.fontEmSize = SkScalarToFloat(fTextSizeRender);
     run.bidiLevel = 0;
     run.glyphIndices = &index;
     run.isSideways = FALSE;
     run.glyphOffsets = &offset;
     {
 
         SkTScopedComPtr<IDWriteGlyphRunAnalysis> glyphRunAnalysis;
-        {
-            SkAutoExclusive l(DWriteFactoryMutex);
-            HRNM(fTypeface->fFactory->CreateGlyphRunAnalysis(&run,
-                1.0f, // pixelsPerDip,
-                &fXform,
-                renderingMode,
-                fMeasuringMode,
-                0.0f, // baselineOriginX,
-                0.0f, // baselineOriginY,
-                &glyphRunAnalysis),
-                "Could not create glyph run analysis.");
-        }
+        HRNM(fTypeface->fFactory->CreateGlyphRunAnalysis(&run,
+            1.0f, // pixelsPerDip,
+            &fXform,
+            renderingMode,
+            fMeasuringMode,
+            0.0f, // baselineOriginX,
+            0.0f, // baselineOriginY,
+            &glyphRunAnalysis),
+            "Could not create glyph run analysis.");
         //NOTE: this assumes that the glyph has already been measured
         //with an exact same glyph run analysis.
         RECT bbox;
         bbox.left = glyph.fLeft;
         bbox.top = glyph.fTop;
         bbox.right = glyph.fLeft + glyph.fWidth;
         bbox.bottom = glyph.fTop + glyph.fHeight;
-        {
-            Shared l(DWriteFactoryMutex);
-            HRNM(glyphRunAnalysis->CreateAlphaTexture(textureType,
-                &bbox,
-                fBits.begin(),
-                sizeNeeded),
-                "Could not draw mask.");
-        }
+        HRNM(glyphRunAnalysis->CreateAlphaTexture(textureType,
+            &bbox,
+            fBits.begin(),
+            sizeNeeded),
+            "Could not draw mask.");
     }
     return fBits.begin();
 }
 
 #if SK_HAS_DWRITE_2_H
 void SkScalerContext_DW::generateColorGlyphImage(const SkGlyph& glyph) {
     SkASSERT(isColorGlyph(glyph));
     SkASSERT(glyph.fMaskFormat == SkMask::Format::kARGB32_Format);
 
     memset(glyph.fImage, 0, glyph.computeImageSize());
@@ skipping 37 matching lines @@
             // If this assert ever fires, we should verify that the color is rendered properly.
             SkASSERT(false);
             color = fRec.getLuminanceColor();
         }
         paint.setColor(color);
 
         SkPath path;
         SkTScopedComPtr<IDWriteGeometrySink> geometryToPath;
         HRVM(SkDWriteGeometrySink::Create(&path, &geometryToPath),
              "Could not create geometry to path converter.");
-        {
-            SkAutoExclusive l(DWriteFactoryMutex);
-            HRVM(colorGlyph->glyphRun.fontFace->GetGlyphRunOutline(
-                colorGlyph->glyphRun.fontEmSize,
-                colorGlyph->glyphRun.glyphIndices,
-                colorGlyph->glyphRun.glyphAdvances,
-                colorGlyph->glyphRun.glyphOffsets,
-                colorGlyph->glyphRun.glyphCount,
-                colorGlyph->glyphRun.isSideways,
-                colorGlyph->glyphRun.bidiLevel % 2, //rtl
-                geometryToPath.get()),
-                "Could not create glyph outline.");
-        }
+        HRVM(colorGlyph->glyphRun.fontFace->GetGlyphRunOutline(
+            colorGlyph->glyphRun.fontEmSize,
+            colorGlyph->glyphRun.glyphIndices,
+            colorGlyph->glyphRun.glyphAdvances,
+            colorGlyph->glyphRun.glyphOffsets,
+            colorGlyph->glyphRun.glyphCount,
+            colorGlyph->glyphRun.isSideways,
+            colorGlyph->glyphRun.bidiLevel % 2, //rtl
+            geometryToPath.get()),
+             "Could not create glyph outline.");
         draw.drawPath(path, paint, nullptr, true /* pathIsMutable */);
     }
 }
 #endif
 
 void SkScalerContext_DW::generateImage(const SkGlyph& glyph) {
     //Create the mask.
     DWRITE_RENDERING_MODE renderingMode = fRenderingMode;
     DWRITE_TEXTURE_TYPE textureType = fTextureType;
     if (glyph.fForceBW) {
@@ skipping 45 matching lines @@
 
 void SkScalerContext_DW::generatePath(const SkGlyph& glyph, SkPath* path) {
     SkASSERT(path);
 
     path->reset();
 
     SkTScopedComPtr<IDWriteGeometrySink> geometryToPath;
     HRVM(SkDWriteGeometrySink::Create(path, &geometryToPath),
          "Could not create geometry to path converter.");
     uint16_t glyphId = glyph.getGlyphID();
-    {
-        SkAutoExclusive l(DWriteFactoryMutex);
-        //TODO: convert to<->from DIUs? This would make a difference if hinting.
-        //It may not be needed, it appears that DirectWrite only hints at em size.
-        HRVM(fTypeface->fDWriteFontFace->GetGlyphRunOutline(SkScalarToFloat(fTextSizeRender),
-            &glyphId,
-            nullptr, //advances
-            nullptr, //offsets
-            1, //num glyphs
-            FALSE, //sideways
-            FALSE, //rtl
-            geometryToPath.get()),
-            "Could not create glyph outline.");
-    }
+    //TODO: convert to<->from DIUs? This would make a difference if hinting.
+    //It may not be needed, it appears that DirectWrite only hints at em size.
+    HRVM(fTypeface->fDWriteFontFace->GetGlyphRunOutline(SkScalarToFloat(fTextSizeRender),
+        &glyphId,
+        nullptr, //advances
+        nullptr, //offsets
+        1, //num glyphs
+        FALSE, //sideways
+        FALSE, //rtl
+        geometryToPath.get()),
+        "Could not create glyph outline.");
 
     path->transform(fSkXform);
 }
 
 #endif//defined(SK_BUILD_FOR_WIN32)