Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2019313003: IC: Eliminate initialization_state as a factor in IC installation. (Closed)

Created:
4 years, 6 months ago by mvstanton
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, v8-x87-ports_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

IC: Eliminate initialization_state as a factor in IC installation. In Crankshaft, we would install special ICs that didn't need a vector and slot in the MEGAMORPHIC case. This optimization limits our hand against future improvements. BUG= Committed: https://crrev.com/56d90782a5a97e1854e9564056f45b6374664d75 Cr-Commit-Position: refs/heads/master@{#36597}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : Fixed compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -506 lines) Patch
M src/code-factory.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/code-factory.cc View 4 chunks +19 lines, -31 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 5 chunks +7 lines, -24 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 5 chunks +7 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 5 chunks +17 lines, -33 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 16 chunks +35 lines, -78 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 5 chunks +7 lines, -24 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 5 chunks +7 lines, -24 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 5 chunks +7 lines, -24 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 5 chunks +7 lines, -24 lines 0 comments Download
M src/ic/ic.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +8 lines, -25 lines 0 comments Download
M src/interpreter/interpreter.cc View 13 chunks +13 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Benedikt, this is the CL we discussed, PTAL, thx! --Mike
4 years, 6 months ago (2016-05-30 12:06:29 UTC) #2
Benedikt Meurer
Also awesome. LGTM.
4 years, 6 months ago (2016-05-30 17:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019313003/40001
4 years, 6 months ago (2016-05-30 19:24:03 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-30 19:26:12 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 19:28:47 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56d90782a5a97e1854e9564056f45b6374664d75
Cr-Commit-Position: refs/heads/master@{#36597}

Powered by Google App Engine
This is Rietveld 408576698