Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/code-factory.cc

Issue 2019313003: IC: Eliminate initialization_state as a factor in IC installation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed compile error. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index dd12b05a811ea91e40946f1ce8f6c43af9dc96af..fd783d6e3c539c9afc19f82cdae03bac1e4dd6ad 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -24,12 +24,10 @@ Callable CodeFactory::ApiGetter(Isolate* isolate) {
}
// static
-Callable CodeFactory::LoadICInOptimizedCode(
- Isolate* isolate, TypeofMode typeof_mode,
- InlineCacheState initialization_state) {
+Callable CodeFactory::LoadICInOptimizedCode(Isolate* isolate,
+ TypeofMode typeof_mode) {
auto code = LoadIC::initialize_stub_in_optimized_code(
- isolate, LoadICState(typeof_mode).GetExtraICState(),
- initialization_state);
+ isolate, LoadICState(typeof_mode).GetExtraICState());
return Callable(code, LoadWithVectorDescriptor(isolate));
}
@@ -42,14 +40,10 @@ Callable CodeFactory::KeyedLoadIC(Isolate* isolate) {
// static
-Callable CodeFactory::KeyedLoadICInOptimizedCode(
- Isolate* isolate, InlineCacheState initialization_state) {
- auto code = KeyedLoadIC::initialize_stub_in_optimized_code(
- isolate, initialization_state, kNoExtraICState);
- if (initialization_state != MEGAMORPHIC) {
- return Callable(code, LoadWithVectorDescriptor(isolate));
- }
- return Callable(code, LoadDescriptor(isolate));
+Callable CodeFactory::KeyedLoadICInOptimizedCode(Isolate* isolate) {
+ auto code =
+ KeyedLoadIC::initialize_stub_in_optimized_code(isolate, kNoExtraICState);
+ return Callable(code, LoadWithVectorDescriptor(isolate));
}
@@ -80,15 +74,12 @@ Callable CodeFactory::StoreIC(Isolate* isolate, LanguageMode language_mode) {
// static
-Callable CodeFactory::StoreICInOptimizedCode(
- Isolate* isolate, LanguageMode language_mode,
- InlineCacheState initialization_state) {
- CallInterfaceDescriptor descriptor = initialization_state != MEGAMORPHIC
- ? VectorStoreICDescriptor(isolate)
- : StoreDescriptor(isolate);
- return Callable(StoreIC::initialize_stub_in_optimized_code(
- isolate, language_mode, initialization_state),
- descriptor);
+Callable CodeFactory::StoreICInOptimizedCode(Isolate* isolate,
+ LanguageMode language_mode) {
+ CallInterfaceDescriptor descriptor = VectorStoreICDescriptor(isolate);
+ return Callable(
+ StoreIC::initialize_stub_in_optimized_code(isolate, language_mode),
+ descriptor);
}
@@ -101,15 +92,12 @@ Callable CodeFactory::KeyedStoreIC(Isolate* isolate,
// static
-Callable CodeFactory::KeyedStoreICInOptimizedCode(
- Isolate* isolate, LanguageMode language_mode,
- InlineCacheState initialization_state) {
- CallInterfaceDescriptor descriptor = initialization_state != MEGAMORPHIC
- ? VectorStoreICDescriptor(isolate)
- : StoreDescriptor(isolate);
- return Callable(KeyedStoreIC::initialize_stub_in_optimized_code(
- isolate, language_mode, initialization_state),
- descriptor);
+Callable CodeFactory::KeyedStoreICInOptimizedCode(Isolate* isolate,
+ LanguageMode language_mode) {
+ CallInterfaceDescriptor descriptor = VectorStoreICDescriptor(isolate);
+ return Callable(
+ KeyedStoreIC::initialize_stub_in_optimized_code(isolate, language_mode),
+ descriptor);
}
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698