Route JS Error Info From Blink to Chrome

Source/web/ChromeClientImpl.h

Index: Source/web/ChromeClientImpl.h
diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h
index 71c4ace37ea4a143f27397e373e3cff838feb1d2..d4a6807daa73a19394218355813f561f06e99126 100644
--- a/Source/web/ChromeClientImpl.h
+++ b/Source/web/ChromeClientImpl.h
@@ -94,10 +94,12 @@ public:
     virtual void setMenubarVisible(bool);
     virtual bool menubarVisible();
     virtual void setResizable(bool);
+    virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>);
+    virtual bool shouldReportDetailedMessageForURL(const WTF::String&);

[abarth-chromium, 2013/07/24 23:59:09]

Maybe this should be a WebSetting?  It seems strange that we would need to call
out to the embedder for each message.  Is this going to change on a
message-by-message basis?

[Devlin, 2013/07/25 00:10:46]

This will change on a message-by-message basis, since we don't (currently) have
any reason to keep/report detailed messages from all sources - for example, we
don't care if a website's js throws an error.  Right now, we only want extra
info if an extension caused the error.

That being said, given that errors are (hopefully) infrequent, and the overhead
shouldn't be too significant for generating/passing the details, it may be worth
it to just always pass them (with a WebSetting), and then determine whether or
not to keep them once we have them.  Preferences?

     virtual void addMessageToConsole(
         WebCore::MessageSource, WebCore::MessageLevel,
         const WTF::String& message, unsigned lineNumber,
-        const WTF::String& sourceID);
+        const WTF::String& sourceID, const WTF::String& details);
     virtual bool canRunBeforeUnloadConfirmPanel();
     virtual bool runBeforeUnloadConfirmPanel(
         const WTF::String& message, WebCore::Frame*);