Route JS Error Info From Blink to Chrome

Source/web/ChromeClientImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 76 matching lines @@
     virtual void runModal();
     virtual void setToolbarsVisible(bool);
     virtual bool toolbarsVisible();
     virtual void setStatusbarVisible(bool);
     virtual bool statusbarVisible();
     virtual void setScrollbarsVisible(bool);
     virtual bool scrollbarsVisible();
     virtual void setMenubarVisible(bool);
     virtual bool menubarVisible();
     virtual void setResizable(bool);
+    virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>);
+    virtual bool shouldReportDetailedMessageForURL(const WTF::String&);

[abarth-chromium, 2013/07/24 23:59:09]

Maybe this should be a WebSetting?  It seems strange that we would need to call
out to the embedder for each message.  Is this going to change on a
message-by-message basis?

[Devlin, 2013/07/25 00:10:46]

This will change on a message-by-message basis, since we don't (currently) have
any reason to keep/report detailed messages from all sources - for example, we
don't care if a website's js throws an error.  Right now, we only want extra
info if an extension caused the error.

That being said, given that errors are (hopefully) infrequent, and the overhead
shouldn't be too significant for generating/passing the details, it may be worth
it to just always pass them (with a WebSetting), and then determine whether or
not to keep them once we have them.  Preferences?

     virtual void addMessageToConsole(
         WebCore::MessageSource, WebCore::MessageLevel,
         const WTF::String& message, unsigned lineNumber,
-        const WTF::String& sourceID);
+        const WTF::String& sourceID, const WTF::String& details);
     virtual bool canRunBeforeUnloadConfirmPanel();
     virtual bool runBeforeUnloadConfirmPanel(
         const WTF::String& message, WebCore::Frame*);
     virtual void closeWindowSoon();
     virtual void runJavaScriptAlert(WebCore::Frame*, const WTF::String&);
     virtual bool runJavaScriptConfirm(WebCore::Frame*, const WTF::String&);
     virtual bool runJavaScriptPrompt(
         WebCore::Frame*, const WTF::String& message,
         const WTF::String& defaultValue, WTF::String& result);
     virtual void setStatusbarText(const WTF::String& message);
@@ skipping 101 matching lines @@
 private:
     explicit NavigatorContentUtilsClientImpl(WebViewImpl*);
 
     WebViewImpl* m_webView;
 };
 #endif
 
 } // namespace WebKit
 
 #endif