cc : Delete LayerImpl::opacity

cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ab317e073bd7b2cb74c405f23008d0a6d4db6270
Cr-Commit-Position: refs/heads/master@{#397000}

[jaydasika, 2016-05-27 01:03:57]

Description was changed from

==========
cc : Stop setting LayerImpl::opacity in LayerImpl::OnOpacityAnimated

Property trees should completely handle opacity animations without
relying on LayerImpl::opacity.

BUG=609205
==========

to

==========
cc : Stop setting LayerImpl::opacity in LayerImpl::OnOpacityAnimated

Property trees should completely handle opacity animations without
relying on LayerImpl::opacity.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-05-27 01:47:45]

Description was changed from

==========
cc : Stop setting LayerImpl::opacity in LayerImpl::OnOpacityAnimated

Property trees should completely handle opacity animations without
relying on LayerImpl::opacity.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-05-27 01:50:52]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-05-27 01:50:53]

PTAL

[jaydasika, 2016-05-27 04:44:54]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 04:45:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018833002/40001

[commit-bot: I haz the power, 2016-05-27 06:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 06:35:29]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-05-27 13:35:44]

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_linear_fade_unittest.cc (right):

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_linear_fade_unittest.cc:59:
scrollbar_layer_->test_properties()->force_render_surface = true;
Is this just to force an effect node? If so, how about adding the equivalent of
Layer::OpacityCanAnimateOnImplThread to LayerImplTestProperties, and checking
that in HasPotentialOpacityAnimation in property_tree_builder.cc? (Incidentally,
LayerImpl::OpacityCanAnimateOnImplThread seems to have no callers, so can be
deleted.)

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_thinning_unittest.cc (right):

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_thinning_unittest.cc:69:
scrollbar_layer_->test_properties()->force_render_surface = true;
Here too, we should have a way to require an effect node without also requiring
a render surface.

[jaydasika, 2016-05-27 17:50:26]

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_linear_fade_unittest.cc (right):

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_linear_fade_unittest.cc:59:
scrollbar_layer_->test_properties()->force_render_surface = true;
On 2016/05/27 13:35:44, ajuma wrote:
> Is this just to force an effect node? If so, how about adding the equivalent
of
> Layer::OpacityCanAnimateOnImplThread to LayerImplTestProperties, and checking
> that in HasPotentialOpacityAnimation in property_tree_builder.cc?
(Incidentally,
> LayerImpl::OpacityCanAnimateOnImplThread seems to have no callers, so can be
> deleted.)

Done.

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_thinning_unittest.cc (right):

https://codereview.chromium.org/2018833002/diff/40001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_thinning_unittest.cc:69:
scrollbar_layer_->test_properties()->force_render_surface = true;
On 2016/05/27 13:35:44, ajuma wrote:
> Here too, we should have a way to require an effect node without also
requiring
> a render surface.

Done.

[ajuma, 2016-05-27 18:23:46]

Thanks, lgtm

[jaydasika, 2016-05-27 18:33:48]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-05-27 18:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018833002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018833002/60001

[commit-bot: I haz the power, 2016-05-27 18:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 18:41:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jaydasika, 2016-05-27 19:03:36]

vollick : Can you review changes to platform/graphics ?

[Ian Vollick, 2016-05-31 21:27:38]

On 2016/05/27 19:03:36, jaydasika wrote:
> vollick : Can you review changes to platform/graphics ?

lgtm.

[jaydasika, 2016-05-31 21:28:21]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018833002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018833002/60001

[commit-bot: I haz the power, 2016-05-31 21:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:32:32]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jaydasika, 2016-05-31 22:06:12]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-05-31 22:06:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2018833002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-31 22:06:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018833002/80001

[commit-bot: I haz the power, 2016-06-01 00:53:30]

Description was changed from

==========
cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-01 00:53:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-01 00:55:09]

Description was changed from

==========
cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc :  Delete LayerImpl::opacity

Since property trees have the required opacity info.

To to this, this CL : (opacity = LayerImpl::opacity)
- Removes pushing opacity at commit and activation.
- Removes SetOpacity in OnOpacityAnimated
- Removes SetOpacity in ScrollbarImplBase::PushPropertiesTo
- For tests, adds opacity to LayerImplTestProperties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ab317e073bd7b2cb74c405f23008d0a6d4db6270
Cr-Commit-Position: refs/heads/master@{#397000}
==========

[commit-bot: I haz the power, 2016-06-01 00:55:10]

Patchset 5 (id:??) landed as
https://crrev.com/ab317e073bd7b2cb74c405f23008d0a6d4db6270
Cr-Commit-Position: refs/heads/master@{#397000}