Issue 2018813002: Split Media.Controls.Show in .Video and .Audio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2018813002: Split Media.Controls.Show in .Video and .Audio. (Closed)

Created:
4 years, 6 months ago by mlamouri (slow - plz ping)

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Split Media.Controls.Show in .Video and .Audio. In order to differentiate metrics coming from audio elements versus coming from video elements. BUG=613178 Review-Url: https://codereview.chromium.org/1990313002 Cr-Commit-Position: refs/heads/master@{#395618} (cherry picked from commit 1c446293173e6c5d20ae437e0b83981907b911c9) Committed: https://chromium.googlesource.com/chromium/src/+/ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -8 lines)			Patch
M	third_party/WebKit/Source/core/html/HTMLMediaElement.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+23 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

mlamouri (slow - plz ping)

4 years, 6 months ago (2016-05-26 23:46:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb.