Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1990313002: Split Media.Controls.Show in .Video and .Audio. (Closed)

Created:
4 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 7 months ago
Reviewers:
whywhat, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split Media.Controls.Show in .Video and .Audio. In order to differentiate metrics coming from audio elements versus coming from video elements. BUG=613178 Committed: https://crrev.com/1c446293173e6c5d20ae437e0b83981907b911c9 Cr-Commit-Position: refs/heads/master@{#395618}

Patch Set 1 #

Patch Set 2 : add more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +15 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +23 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mlamouri (slow - plz ping)
isherman@, PTAL
4 years, 7 months ago (2016-05-19 16:13:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990313002/20001
4 years, 7 months ago (2016-05-19 16:17:13 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/114264)
4 years, 7 months ago (2016-05-19 17:12:28 UTC) #6
Ilya Sherman
lgtm
4 years, 7 months ago (2016-05-19 21:43:45 UTC) #7
mlamouri (slow - plz ping)
+avayvod@
4 years, 7 months ago (2016-05-20 09:20:15 UTC) #9
whywhat
lgtm although the code in showControlsHistogram looks a bit odd :/
4 years, 7 months ago (2016-05-23 11:15:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990313002/20001
4 years, 7 months ago (2016-05-24 12:49:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 17:03:05 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 17:04:20 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c446293173e6c5d20ae437e0b83981907b911c9
Cr-Commit-Position: refs/heads/master@{#395618}

Powered by Google App Engine
This is Rietveld 408576698