Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2018753002: [MD settings] refine routing function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_animated_pages.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/basic_page/basic_page.html
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html
index 6dfcc3bd2680719a45938afb8998ec690fbe426e..b8cf49b5fb7b149787007a33723a44413d6eb364 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.html
+++ b/chrome/browser/resources/settings/basic_page/basic_page.html
@@ -22,71 +22,74 @@
<dom-module id="settings-basic-page">
<template>
<style include="settings-page-styles"></style>
- <template is="dom-if" if="[[showResetProfileBanner_]]">
- <settings-reset-profile-banner on-reset-done="onResetDone_">
- </settings-reset-profile-banner>
- </template>
+ <div data-page="basic">
+ <template is="dom-if" if="[[showResetProfileBanner_]]">
+ <settings-reset-profile-banner on-reset-done="onResetDone_">
+ </settings-reset-profile-banner>
+ </template>
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.internet)]]" restamp>
- <settings-section page-title="$i18n{internetPageTitle}"
- current-route="[[currentRoute]]" section="internet">
- <settings-internet-page current-route="{{currentRoute}}">
- </settings-internet-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.internet)]]" restamp>
+ <settings-section page-title="$i18n{internetPageTitle}"
+ current-route="[[currentRoute]]" section="internet">
+ <settings-internet-page current-route="{{currentRoute}}">
+ </settings-internet-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
- <settings-section page-title="$i18n{peoplePageTitle}"
- current-route="[[currentRoute]]" section="people">
- <settings-people-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-people-page>
- </settings-section>
- </template>
- <template is="dom-if" if="[[showPage(pageVisibility.appearance)]]" restamp>
- <settings-section page-title="$i18n{appearancePageTitle}"
- current-route="[[currentRoute]]" section="appearance">
- <settings-appearance-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-appearance-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
+ <settings-section page-title="$i18n{peoplePageTitle}"
+ current-route="[[currentRoute]]" section="people">
+ <settings-people-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-people-page>
+ </settings-section>
+ </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.appearance)]]"
+ restamp>
+ <settings-section page-title="$i18n{appearancePageTitle}"
+ current-route="[[currentRoute]]" section="appearance">
+ <settings-appearance-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-appearance-page>
+ </settings-section>
+ </template>
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.device)]]" restamp>
- <settings-section page-title="$i18n{devicePageTitle}"
- current-route="[[currentRoute]]" section="device">
- <settings-device-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-device-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.device)]]" restamp>
+ <settings-section page-title="$i18n{devicePageTitle}"
+ current-route="[[currentRoute]]" section="device">
+ <settings-device-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-device-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.search)]]" restamp>
- <settings-section page-title="$i18n{searchPageTitle}"
- current-route="[[currentRoute]]" section="search">
- <settings-search-page current-route="{{currentRoute}}">
- </settings-search-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.search)]]" restamp>
+ <settings-section page-title="$i18n{searchPageTitle}"
+ current-route="[[currentRoute]]" section="search">
+ <settings-search-page current-route="{{currentRoute}}">
+ </settings-search-page>
+ </settings-section>
+ </template>
<if expr="not chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.defaultBrowser)]]"
- restamp>
- <settings-section page-title="$i18n{defaultBrowser}"
- expand-container="{{expandContainer}}"
- current-route="[[currentRoute]]" section="defaultBrowser">
- <settings-default-browser-page>
- </settings-default-browser-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.defaultBrowser)]]"
+ restamp>
+ <settings-section page-title="$i18n{defaultBrowser}"
+ expand-container="{{expandContainer}}"
+ current-route="[[currentRoute]]" section="defaultBrowser">
+ <settings-default-browser-page>
+ </settings-default-browser-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.onStartup)]]" restamp>
- <settings-section page-title="$i18n{onStartup}"
- current-route="[[currentRoute]]" section="onStartup">
- <settings-on-startup-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-on-startup-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.onStartup)]]" restamp>
+ <settings-section page-title="$i18n{onStartup}"
+ current-route="[[currentRoute]]" section="onStartup">
+ <settings-on-startup-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-on-startup-page>
+ </settings-section>
+ </template>
+ </div>
</template>
<script src="basic_page.js"></script>
</dom-module>
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_animated_pages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698