Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 2018753002: [MD settings] refine routing function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.html ('k') | chrome/browser/resources/settings/basic_page/basic_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/advanced_page/advanced_page.html
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html
index 555dc0f21d6ecba294215389f6cee02a7ba69399..662602ea3b0dce30362f4501ea56f3611e712d58 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html
@@ -25,80 +25,82 @@
<dom-module id="settings-advanced-page">
<template>
<style include="settings-page-styles"></style>
+ <div data-page="advanced">
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]" restamp>
- <settings-section page-title="$i18n{dateTimePageTitle}"
- current-route="[[currentRoute]]" section="dateTime">
- <settings-date-time-page prefs="{{prefs}}">
- </settings-date-time-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]" restamp>
+ <settings-section page-title="$i18n{dateTimePageTitle}"
+ current-route="[[currentRoute]]" section="dateTime">
+ <settings-date-time-page prefs="{{prefs}}">
+ </settings-date-time-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.privacy)]]" restamp>
- <settings-section page-title="$i18n{privacyPageTitle}"
- current-route="[[currentRoute]]" section="privacy">
- <settings-privacy-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-privacy-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.privacy)]]" restamp>
+ <settings-section page-title="$i18n{privacyPageTitle}"
+ current-route="[[currentRoute]]" section="privacy">
+ <settings-privacy-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-privacy-page>
+ </settings-section>
+ </template>
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.bluetooth)]]" restamp>
- <settings-section page-title="$i18n{bluetoothPageTitle}"
- current-route="[[currentRoute]]" section="bluetooth">
- <settings-bluetooth-page current-route="{{currentRoute}}">
- </settings-bluetooth-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.bluetooth)]]" restamp>
+ <settings-section page-title="$i18n{bluetoothPageTitle}"
+ current-route="[[currentRoute]]" section="bluetooth">
+ <settings-bluetooth-page current-route="{{currentRoute}}">
+ </settings-bluetooth-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.passwordsAndForms)]]"
- restamp>
- <settings-section
- page-title="$i18n{passwordsAndAutofillPageTitle}"
- current-route="[[currentRoute]]" section="passwordsAndForms">
- <settings-passwords-and-forms-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-passwords-and-forms-page>
- </settings-section>
- </template>
- <template is="dom-if" if="[[showPage(pageVisibility.languages)]]" restamp>
- <settings-section page-title="$i18n{languagesPageTitle}"
- current-route="[[currentRoute]]" section="languages">
- <settings-languages-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
- </settings-languages-page>
- </settings-section>
- </template>
- <template is="dom-if" if="[[showPage(pageVisibility.downloads)]]" restamp>
- <settings-section page-title="$i18n{downloadsPageTitle}"
- current-route="[[currentRoute]]" section="downloads">
- <settings-downloads-page prefs="{{prefs}}">
- </settings-downloads-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.passwordsAndForms)]]"
+ restamp>
+ <settings-section
+ page-title="$i18n{passwordsAndAutofillPageTitle}"
+ current-route="[[currentRoute]]" section="passwordsAndForms">
+ <settings-passwords-and-forms-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-passwords-and-forms-page>
+ </settings-section>
+ </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.languages)]]" restamp>
+ <settings-section page-title="$i18n{languagesPageTitle}"
+ current-route="[[currentRoute]]" section="languages">
+ <settings-languages-page prefs="{{prefs}}"
+ current-route="{{currentRoute}}">
+ </settings-languages-page>
+ </settings-section>
+ </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.downloads)]]" restamp>
+ <settings-section page-title="$i18n{downloadsPageTitle}"
+ current-route="[[currentRoute]]" section="downloads">
+ <settings-downloads-page prefs="{{prefs}}">
+ </settings-downloads-page>
+ </settings-section>
+ </template>
- <!-- TODO(dschuyler): Add Google Cloud Print section here. -->
+ <!-- TODO(dschuyler): Add Google Cloud Print section here. -->
- <template is="dom-if" if="[[showPage(pageVisibility.a11y)]]" restamp>
- <settings-section page-title="$i18n{a11yPageTitle}"
- current-route="[[currentRoute]]" section="a11y">
- <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.a11y)]]" restamp>
+ <settings-section page-title="$i18n{a11yPageTitle}"
+ current-route="[[currentRoute]]" section="a11y">
+ <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
+ </settings-section>
+ </template>
<if expr="not chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.system)]]" restamp>
- <settings-section page-title="$i18n{systemPageTitle}"
- current-route="[[currentRoute]]" section="system">
- <settings-system-page prefs="{{prefs}}"></settings-system-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.system)]]" restamp>
+ <settings-section page-title="$i18n{systemPageTitle}"
+ current-route="[[currentRoute]]" section="system">
+ <settings-system-page prefs="{{prefs}}"></settings-system-page>
+ </settings-section>
+ </template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.reset)]]" restamp>
- <settings-section page-title="$i18n{resetPageTitle}"
- current-route="[[currentRoute]]" section="reset">
- <settings-reset-page></settings-reset-page>
- </settings-section>
- </template>
+ <template is="dom-if" if="[[showPage(pageVisibility.reset)]]" restamp>
+ <settings-section page-title="$i18n{resetPageTitle}"
+ current-route="[[currentRoute]]" section="reset">
+ <settings-reset-page></settings-reset-page>
+ </settings-section>
+ </template>
+ </div>
</template>
<script src="/advanced_page/advanced_page.js"></script>
</dom-module>
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.html ('k') | chrome/browser/resources/settings/basic_page/basic_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698