Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018733003: Fix Visual Studio warning on single file compilation (Closed)

Created:
4 years, 6 months ago by Tomasz Moniuszko
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Visual Studio warning on single file compilation BUG=615402 Committed: https://crrev.com/a7e95b0468908825cdafa072ed1b8f99f3859a93 Cr-Commit-Position: refs/heads/master@{#396693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 6 months ago (2016-05-27 14:42:36 UTC) #2
brettw
lgtm
4 years, 6 months ago (2016-05-27 17:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018733003/1
4 years, 6 months ago (2016-05-30 07:19:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 08:20:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 08:22:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a7e95b0468908825cdafa072ed1b8f99f3859a93
Cr-Commit-Position: refs/heads/master@{#396693}

Powered by Google App Engine
This is Rietveld 408576698