tools/gn/visual_studio_writer.cc - Issue 2018733003: Fix Visual Studio warning on single file compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/visual_studio_writer.cc

Issue 2018733003: Fix Visual Studio warning on single file compilation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/visual_studio_writer.cc

diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc

index 50d6878a5f194355494fd96e831a5e2e6993f2ab..7dedd4d302066e1778bf3128e87ac9f86aa98599 100644

--- a/tools/gn/visual_studio_writer.cc

+++ b/tools/gn/visual_studio_writer.cc

@@ -432,7 +432,7 @@ bool VisualStudioWriter::WriteProjectFileContents(

properties->SubElement("OutDir");

path_output.WriteDir(out_dir->StartContent(false),

build_settings_->build_dir(),

- PathOutput::DIR_NO_LAST_SLASH);

+ PathOutput::DIR_INCLUDE_LAST_SLASH);

}

properties->SubElement("TargetName")->Text("$(ProjectName)");

if (target->output_type() != Target::GROUP) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »