Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018543002: Fix -Wwritable-strings warnings in kasko code. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews, manzagop (departed), Patrick Monette
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -Wwritable-strings warnings in kasko code. Should fix 32-bit clang/win builds after https://codereview.chromium.org/405123002/ BUG=82385 TBR=hans Committed: https://crrev.com/66c18298fb5cb303081a9588690eec1685f0f79c Cr-Commit-Position: refs/heads/master@{#396187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/chrome_watcher/system_load_estimator.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
4 years, 7 months ago (2016-05-26 14:40:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018543002/1
4 years, 7 months ago (2016-05-26 14:40:42 UTC) #3
hans
lgtm
4 years, 7 months ago (2016-05-26 15:27:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 15:45:22 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 15:46:56 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66c18298fb5cb303081a9588690eec1685f0f79c
Cr-Commit-Position: refs/heads/master@{#396187}

Powered by Google App Engine
This is Rietveld 408576698