Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2018403002: [turbofan] Emit explicit checkpoint before operations. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Emit explicit checkpoint before operations. This is a first step towards explicit checkpoints in the graph. For now we still use the explicit eager bailout points in the AstGraphBuilder that are marked by the FrameStateBeforeAndAfter helper. Eventually these will be implicitly emitted by expression visits having a side-effect. R=bmeurer@chromium.org BUG=v8:5021 Committed: https://crrev.com/e065d3eff8595f0197705a7d0e4b0fa8970e38e4 Cr-Commit-Position: refs/heads/master@{#36638}

Patch Set 1 #

Patch Set 2 : Fixes left and right. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 6 months ago (2016-05-30 12:20:22 UTC) #3
Michael Starzinger
PTAL. This should be ready for prime time by now.
4 years, 6 months ago (2016-06-01 10:34:45 UTC) #4
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-01 10:42:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018403002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018403002/50001
4 years, 6 months ago (2016-06-01 10:45:16 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 6 months ago (2016-06-01 10:47:45 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 10:48:44 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e065d3eff8595f0197705a7d0e4b0fa8970e38e4
Cr-Commit-Position: refs/heads/master@{#36638}

Powered by Google App Engine
This is Rietveld 408576698