Issue 2018353006: DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2018353006: DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile. (Closed)

Created:
4 years, 6 months ago by alph

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile. Do not pass object literals into dispatchMessage API. Always turn it into a string. BUG=614860 Review-Url: https://codereview.chromium.org/2022673002 Cr-Commit-Position: refs/heads/master@{#396633} (cherry picked from commit a2b2954002b9f46a902bb23ed6a11ba4c0604096) Committed: https://chromium.googlesource.com/chromium/src/+/172c3abbe1f4c439df2e1259a75b11f4b1195e94

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	chrome/browser/devtools/devtools_ui_bindings.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	content/shell/browser/shell_devtools_frontend.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 2 (1 generated)

alph

4 years, 6 months ago (2016-05-31 08:38:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
172c3abbe1f4c439df2e1259a75b11f4b1195e94.