DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.

DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.

Do not pass object literals into dispatchMessage API. Always turn it into a string.

BUG=614860
Committed: https://crrev.com/a2b2954002b9f46a902bb23ed6a11ba4c0604096
Cr-Commit-Position: refs/heads/master@{#396633}

[alph, 2016-05-28 01:37:50]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-05-28 01:43:14]

https://codereview.chromium.org/2022673002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-deep-nesting.html
(right):

https://codereview.chromium.org/2022673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-deep-nesting.html:23:
InspectorTest.evaluateInPage("f = d => d ? f(d - 1) :
console.profile('profile'); f(1000); console.profileEnd('profile');", () => 0);
Lets test what you fix.

[alph, 2016-05-28 02:21:22]

Description was changed from

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

The CPU profile is represented as an object literal when it is passed to
frontend.
V8 cannot parse object literals with nesting more than ~500 depth.
To workaround that limit set the max chunk size to 20K, so CPU profiles would go
through
dispatchMessageChunk API which can handle that.

BUG=614860
==========

to

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

Do not pass object literals into dispatchMessage API. Always turn it into a
string.

BUG=614860
==========

[alph, 2016-05-28 02:21:52]

ptal

https://codereview.chromium.org/2022673002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-deep-nesting.html
(right):

https://codereview.chromium.org/2022673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-deep-nesting.html:23:
InspectorTest.evaluateInPage("f = d => d ? f(d - 1) :
console.profile('profile'); f(1000); console.profileEnd('profile');", () => 0);
On 2016/05/28 01:43:14, pfeldman wrote:
> Lets test what you fix.

Redone everything.

[pfeldman, 2016-05-28 02:26:03]

https://codereview.chromium.org/2022673002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2022673002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:274:
base::JSONWriter::Write(base::StringValue(message), &param);
EscapeJSONString

[pfeldman, 2016-05-28 02:26:08]

lgtm

[alph, 2016-05-28 02:36:41]

The CQ bit was checked by alph@chromium.org

[alph, 2016-05-28 02:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2022673002/#ps40001
(title: "Use EscapeJSONString")

[commit-bot: I haz the power, 2016-05-28 02:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022673002/40001

[alph, 2016-05-28 02:37:03]

https://codereview.chromium.org/2022673002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2022673002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:274:
base::JSONWriter::Write(base::StringValue(message), &param);
On 2016/05/28 02:26:03, pfeldman wrote:
> EscapeJSONString

Done.

[commit-bot: I haz the power, 2016-05-28 04:06:26]

Description was changed from

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

Do not pass object literals into dispatchMessage API. Always turn it into a
string.

BUG=614860
==========

to

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

Do not pass object literals into dispatchMessage API. Always turn it into a
string.

BUG=614860
==========

[commit-bot: I haz the power, 2016-05-28 04:06:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-28 04:07:51]

Description was changed from

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

Do not pass object literals into dispatchMessage API. Always turn it into a
string.

BUG=614860
==========

to

==========
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU
profile.

Do not pass object literals into dispatchMessage API. Always turn it into a
string.

BUG=614860

Committed: https://crrev.com/a2b2954002b9f46a902bb23ed6a11ba4c0604096
Cr-Commit-Position: refs/heads/master@{#396633}
==========

[commit-bot: I haz the power, 2016-05-28 04:07:55]

Patchset 3 (id:??) landed as
https://crrev.com/a2b2954002b9f46a902bb23ed6a11ba4c0604096
Cr-Commit-Position: refs/heads/master@{#396633}