views/mus: Add support for child widgets.

views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820
Committed: https://crrev.com/53b0bb0c43383a45fb9df294782ecc2bfa333f2b
Cr-Commit-Position: refs/heads/master@{#396917}

[sadrul, 2016-05-30 14:05:16]

Description was changed from

==========
views/mus: Add support for child widgets.

...

BUG=...
==========

to

==========
views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820
==========

[sadrul, 2016-05-30 14:06:34]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-05-31 17:00:57]

https://codereview.chromium.org/2018333002/diff/20001/ui/views/mus/window_man...
File ui/views/mus/window_manager_connection.cc (right):

https://codereview.chromium.org/2018333002/diff/20001/ui/views/mus/window_man...
ui/views/mus/window_manager_connection.cc:72: return nullptr;
Add comment as to what ends up handling this.

https://codereview.chromium.org/2018333002/diff/20001/ui/views/widget/native_...
File ui/views/widget/native_widget_aura.cc (left):

https://codereview.chromium.org/2018333002/diff/20001/ui/views/widget/native_...
ui/views/widget/native_widget_aura.cc:1160: aura::Window* root_window =
native_view->GetRootWindow();
Why is this code no longer necessary?

[sadrul, 2016-05-31 17:25:14]

https://codereview.chromium.org/2018333002/diff/20001/ui/views/mus/window_man...
File ui/views/mus/window_manager_connection.cc (right):

https://codereview.chromium.org/2018333002/diff/20001/ui/views/mus/window_man...
ui/views/mus/window_manager_connection.cc:72: return nullptr;
On 2016/05/31 17:00:57, sky wrote:
> Add comment as to what ends up handling this.

Done.

https://codereview.chromium.org/2018333002/diff/20001/ui/views/widget/native_...
File ui/views/widget/native_widget_aura.cc (left):

https://codereview.chromium.org/2018333002/diff/20001/ui/views/widget/native_...
ui/views/widget/native_widget_aura.cc:1160: aura::Window* root_window =
native_view->GetRootWindow();
On 2016/05/31 17:00:57, sky wrote:
> Why is this code no longer necessary?

As the comment suggests, this isn't really correct. The intention of the calling
code (NativeViewHostAura::NativeViewDetaching()) is to actually remove the
window from the window-tree, whereas this code ends up parenting it to the
root-window instead. This introduces problems with ownership of the window
(since the root-window takes ownership).

This change was made a while back
(https://chromiumcodereview.appspot.com/11421006) during the desktop-aura
transition. I suspect it might have been necessary at the time, but I doubt this
is necessary anymore. I tried out the places where this is used (sad-tab,
find-in-page, and they seem to work OK after this change on desktop-linux and
chromeos builds)

[sky, 2016-05-31 20:04:32]

LGTM

[sadrul, 2016-05-31 20:26:34]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-05-31 20:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018333002/40001

[commit-bot: I haz the power, 2016-05-31 20:33:33]

Description was changed from

==========
views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820
==========

to

==========
views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820
==========

[commit-bot: I haz the power, 2016-05-31 20:33:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-31 20:45:22]

Description was changed from

==========
views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820
==========

to

==========
views/mus: Add support for child widgets.

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820

Committed: https://crrev.com/53b0bb0c43383a45fb9df294782ecc2bfa333f2b
Cr-Commit-Position: refs/heads/master@{#396917}
==========

[commit-bot: I haz the power, 2016-05-31 20:45:24]

Patchset 3 (id:??) landed as
https://crrev.com/53b0bb0c43383a45fb9df294782ecc2bfa333f2b
Cr-Commit-Position: refs/heads/master@{#396917}