views/mus: Add support for child widgets.

ui/views/widget/native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
 #include "build/build_config.h"
@@ skipping 1125 matching lines @@
   Widget::Widgets widgets;
   GetAllChildWidgets(native_view, &widgets);
 
   // First notify all the widgets that they are being disassociated
   // from their previous parent.
   for (Widget::Widgets::iterator it = widgets.begin();
       it != widgets.end(); ++it) {
     (*it)->NotifyNativeViewHierarchyWillChange();
   }
 
-  if (new_parent) {
+  if (new_parent)
     new_parent->AddChild(native_view);
-  } else {
-    // The following looks weird, but it's the equivalent of what aura has
-    // always done. (The previous behaviour of aura::Window::SetParent() used
-    // NULL as a special value that meant ask the WindowTreeClient where things
-    // should go.)
-    //
-    // This probably isn't strictly correct, but its an invariant that a Window
-    // in use will be attached to a RootWindow, so we can't just call
-    // RemoveChild here. The only possible thing that could assign a RootWindow
-    // in this case is the stacking client of the current RootWindow. This
-    // matches our previous behaviour; the global stacking client would almost
-    // always reattach the window to the same RootWindow.
-    aura::Window* root_window = native_view->GetRootWindow();

[sky, 2016/05/31 17:00:57]

Why is this code no longer necessary?

[sadrul, 2016/05/31 17:25:14]

As the comment suggests, this isn't really correct. The intention of the calling
code (NativeViewHostAura::NativeViewDetaching()) is to actually remove the
window from the window-tree, whereas this code ends up parenting it to the
root-window instead. This introduces problems with ownership of the window
(since the root-window takes ownership).

This change was made a while back
(https://chromiumcodereview.appspot.com/11421006) during the desktop-aura
transition. I suspect it might have been necessary at the time, but I doubt this
is necessary anymore. I tried out the places where this is used (sad-tab,
find-in-page, and they seem to work OK after this change on desktop-linux and
chromeos builds)

-    aura::client::ParentWindowWithContext(
-        native_view, root_window, root_window->GetBoundsInScreen());
-  }
+  else if (previous_parent)
+    previous_parent->RemoveChild(native_view);
 
   // And now, notify them that they have a brand new parent.
   for (Widget::Widgets::iterator it = widgets.begin();
       it != widgets.end(); ++it) {
     (*it)->NotifyNativeViewHierarchyChanged();
   }
 }
 
 // static
 bool NativeWidgetPrivate::IsMouseButtonDown() {
@@ skipping 18 matching lines @@
     gfx::NativeView native_view) {
   aura::client::CaptureClient* capture_client =
       aura::client::GetCaptureClient(native_view->GetRootWindow());
   if (!capture_client)
     return nullptr;
   return capture_client->GetGlobalCaptureWindow();
 }
 
 }  // namespace internal
 }  // namespace views