Issue 20182002: Make inttypes.h and similar macro usage C++11-friendly.

Issue 20182002: Make inttypes.h and similar macro usage C++11-friendly. (Closed)

Created:
7 years, 5 months ago by Nico

Modified:
7 years, 5 months ago

Reviewers:
Avi (use Gerrit), brettw, Ryan Sleevi, Lei Zhang, alecflett, enne (OOO), dmichael (off chromium), Alexei Svitkine (slow), alokp, Ilya Sherman

CC:
chromium-reviews, extensions-reviews_chromium.org, Raman Kakilate, jam, estade+watch_chromium.org, benquan, browser-components-watch_chromium.org, ahutter, kkania, frankf, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make inttypes.h and similar macro usage C++11-friendly. "foo"PRIuS is a user-defined literal in C++11. Add spaces around these macros. Likewise, L"\xab"L"c" is a user-defined literal, so insert a space in the middle. No functionality change. BUG=chromium:263960 TBR=alokp@chromium.org, dmichael@chromium.org, enne@chromium.org, isherman@chromium.org, rsleevi@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213566

Patch Set 1 #

Patch Set 2 : common.gypi #

Total comments: 2

Patch Set 3 : line #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -97 lines)			Patch
M	build/common.gypi	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	cc/scheduler/scheduler_state_machine.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_protocols.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/browser_feature_extractor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/server/http_response.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/webdriver/http_response.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	components/autofill/content/browser/autocheckout/whitelist_manager_unittest.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/common/content_param_traits.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/embedded_test_server/http_response.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/get_server_time/get_server_time.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/file_downloader.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/local_temp_file.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/module_ppapi.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View		14 chunks	+15 lines, -15 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View		20 chunks	+24 lines, -24 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/scriptable_plugin.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/temporary_file.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/utility.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/weak_ref/call_on_main_thread.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	skia/ext/image_operations_bench.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/leveldatabase/chromium_logger.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/render_text_unittest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/message_center/cocoa/status_item_view.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	url/url_canon_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Nico

enne: cc dmichael: ppapi thestig: chrome isherman: components/autofill rsleevi: net/ alecflet: third_party/leveldatabase brettw: url/ alokp: ...

7 years, 5 months ago (2013-07-24 23:04:05 UTC) #1

dmichael (off chromium)

ppapi/ lgtm w/nit https://codereview.chromium.org/20182002/diff/4001/ppapi/native_client/src/trusted/plugin/utility.h File ppapi/native_client/src/trusted/plugin/utility.h (right): https://codereview.chromium.org/20182002/diff/4001/ppapi/native_client/src/trusted/plugin/utility.h#newcode47 ppapi/native_client/src/trusted/plugin/utility.h:47: ::plugin::NaClPluginPrintLog("PLUGIN %" NACL_PRIu64 ": ", \ ...

7 years, 5 months ago (2013-07-25 00:51:05 UTC) #8

Nico

https://codereview.chromium.org/20182002/diff/4001/ppapi/native_client/src/trusted/plugin/utility.h File ppapi/native_client/src/trusted/plugin/utility.h (right): https://codereview.chromium.org/20182002/diff/4001/ppapi/native_client/src/trusted/plugin/utility.h#newcode47 ppapi/native_client/src/trusted/plugin/utility.h:47: ::plugin::NaClPluginPrintLog("PLUGIN %" NACL_PRIu64 ": ", \ Done.

7 years, 5 months ago (2013-07-25 00:52:34 UTC) #9

Nico

Committed patchset #3 manually as r213566 (presubmit successful).

7 years, 5 months ago (2013-07-25 00:56:22 UTC) #10

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages