chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 20182002: Make inttypes.h and similar macro usage C++11-friendly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 20182002: Make inttypes.h and similar macro usage C++11-friendly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: line Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor.cc ('k') | chrome/test/chromedriver/server/http_response.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/i18n/rtl.h"	5 #include "base/i18n/rtl.h"

6 #include "base/path_service.h"	6 #include "base/path_service.h"

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "chrome/common/chrome_paths.h"	8 #include "chrome/common/chrome_paths.h"

9 #include "chrome/common/extensions/extension.h"	9 #include "chrome/common/extensions/extension.h"

10 #include "chrome/common/extensions/extension_manifest_constants.h"	10 #include "chrome/common/extensions/extension_manifest_constants.h"

(...skipping 132 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
143 scoped_refptr<Extension> extension(LoadAndExpectSuccess(	143 scoped_refptr<Extension> extension(LoadAndExpectSuccess(

144 "init_valid_name_no_rtl.json"));	144 "init_valid_name_no_rtl.json"));

145	145

146 string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));	146 string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));

147 base::i18n::AdjustStringForLocaleDirection(&localized_name);	147 base::i18n::AdjustStringForLocaleDirection(&localized_name);

148 EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));	148 EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));

149	149

150 // Strong RTL characters in name.	150 // Strong RTL characters in name.

151 extension = LoadAndExpectSuccess("init_valid_name_strong_rtl.json");	151 extension = LoadAndExpectSuccess("init_valid_name_strong_rtl.json");

152	152

153 localized_name = WideToUTF16(L"Dictionary (\x05D1\x05D2"L" Google)");	153 localized_name = WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)");

154 base::i18n::AdjustStringForLocaleDirection(&localized_name);	154 base::i18n::AdjustStringForLocaleDirection(&localized_name);

155 EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));	155 EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));

156	156

157 // Reset locale.	157 // Reset locale.

158 #if defined(TOOLKIT_GTK)	158 #if defined(TOOLKIT_GTK)

159 gtk_widget_set_default_direction(gtk_dir);	159 gtk_widget_set_default_direction(gtk_dir);

160 #else	160 #else

161 base::i18n::SetICUDefaultLocale(locale);	161 base::i18n::SetICUDefaultLocale(locale);

162 #endif	162 #endif

163 }	163 }

164	164

165 } // namespace extensions	165 } // namespace extensions

OLD	NEW