Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2018063002: Revert of Show message center on lock screen (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, lhchavez+watch_chromium.org, kalyank, hidehiko+watch_chomium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show message center on lock screen (patchset #2 id:120001 of https://codereview.chromium.org/1986493002/ ) Reason for revert: Speculative revert: this may cause message_center_unittests failure on Ubuntu-12.04 BUG=615443 Original issue's description: > Show message center on lock screen > > This patch does: > - Show the message center button on tray on the lock screen > - Show the message to encourage user to log in when user opens message center on lock screen > - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. > - Don't make notifications read when opening the message center on lock screen > - Add tests > > And this patch also fixes the bug that this makes blocked notifications read wrongly. > > BUG=599891 > TEST=manually tested > > Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 > Cr-Commit-Position: refs/heads/master@{#396402} TBR=dewittj@chromium.org,skuhne@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599891 Committed: https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676 Cr-Commit-Position: refs/heads/master@{#396495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -202 lines) Patch
M ash/system/web_notification/web_notification_tray.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ui/message_center/fake_message_center.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/message_center/fake_message_center.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/message_center/message_center.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/message_center/message_center_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 8 chunks +16 lines, -28 lines 0 comments Download
M ui/message_center/message_center_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/message_center/notification_list.h View 3 chunks +9 lines, -6 lines 0 comments Download
M ui/message_center/notification_list.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 3 chunks +0 lines, -4 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 7 chunks +7 lines, -21 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 8 chunks +0 lines, -101 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Revert of Show message center on lock screen
4 years, 6 months ago (2016-05-27 17:07:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018063002/1
4 years, 6 months ago (2016-05-27 17:07:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 17:08:18 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:09:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676
Cr-Commit-Position: refs/heads/master@{#396495}

Powered by Google App Engine
This is Rietveld 408576698