Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2361)

Unified Diff: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h

Issue 2017813004: Added popup that shows the new Back shortcut on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@backspace-new-shortcut-bubble
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
diff --git a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
index ef5a231406683c8778e2d4e542b99ddb6999c737..e61af22fa664a065f01d843ceb94941ce6dc2553 100644
--- a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
+++ b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
@@ -25,9 +25,10 @@ class BrowserWindow;
class ExclusiveAccessBubbleViews;
@class ExclusiveAccessBubbleWindowController;
class GURL;
+class NewBackShortcutBubble;
// Component placed into a browser window controller to manage communication
-// with the exclusive access bubble, which appears for events such as entering
+// with subtle notification bubbles, which appear for events such as entering
// fullscreen.
class ExclusiveAccessController : public ExclusiveAccessContext,
public ui::AcceleratorProvider,
@@ -46,6 +47,9 @@ class ExclusiveAccessController : public ExclusiveAccessContext,
// Shows the bubble once the NSWindow has received -windowDidEnterFullScreen:.
void Show();
+ // Shows the new Back shortcut bubble.
+ void ShowNewBackShortcutBubble(bool forward);
+
// Closes any open bubble.
void Destroy();
@@ -100,6 +104,10 @@ class ExclusiveAccessController : public ExclusiveAccessContext,
std::unique_ptr<ExclusiveAccessBubbleViews> views_bubble_;
base::scoped_nsobject<ExclusiveAccessBubbleWindowController> cocoa_bubble_;
+ // This class also manages the new Back shortcut bubble (which functions the
+ // same way as ExclusiveAccessBubbleViews).
+ std::unique_ptr<NewBackShortcutBubble> new_back_shortcut_bubble_;
+
// Used to keep track of the kShowFullscreenToolbar preference.
PrefChangeRegistrar pref_registrar_;
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698