Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2017813002: Implement DISALLOW_COPY_AND_ASSIGN using =delete, stage two. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DISALLOW_COPY_AND_ASSIGN using =delete, stage two. This enables the new implementation on all platforms, but only for non-branded builds. Since the CQ doesn't include these by default, the chance of breaking them is greater. Stage three will be to enable this all the time. BUG=447156 TEST=none TBR=thakis Committed: https://crrev.com/bdc5de32680409490c41c7ad54f3abe32c4a5094 Cr-Commit-Position: refs/heads/master@{#396380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M base/macros.h View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Peter Kasting
FYI (TBRing because this is a subset of the original full rollout you already OKed)
4 years, 7 months ago (2016-05-26 23:38:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017813002/1
4 years, 7 months ago (2016-05-27 02:07:42 UTC) #5
Nico
On 2016/05/27 02:07:42, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-27 02:20:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 04:33:05 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 04:36:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdc5de32680409490c41c7ad54f3abe32c4a5094
Cr-Commit-Position: refs/heads/master@{#396380}

Powered by Google App Engine
This is Rietveld 408576698