Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2635)

Unified Diff: base/macros.h

Issue 2017813002: Implement DISALLOW_COPY_AND_ASSIGN using =delete, stage two. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/macros.h
diff --git a/base/macros.h b/base/macros.h
index 0a0b3148639b67607588175d3c8adb2e51a75fe2..d03deee246dc6618c12646125082adb544e8dead 100644
--- a/base/macros.h
+++ b/base/macros.h
@@ -12,8 +12,6 @@
#include <stddef.h> // For size_t.
-#include "build/build_config.h" // For OS_XXX. TODO(pkasting): Remove.
-
// Put this in the declarations for a class to be uncopyable.
#define DISALLOW_COPY(TypeName) \
TypeName(const TypeName&) = delete
@@ -24,10 +22,10 @@
// A macro to disallow the copy constructor and operator= functions.
// This should be used in the private: declarations for a class.
-// TODO(pkasting): Using "= delete" is Linux-specific initially to prevent
-// cross-platform code from regressing while other platforms are fixed. Remove
-// the ifdefs here and use "= delete" on all platforms.
-#if defined(CHROMIUM_BUILD) && defined(OS_LINUX) && !defined(OS_CHROMEOS)
+// TODO(pkasting): Using "= delete" is non-branded-build-specific initially to
+// limit the rollout to reduce the chance of build breakage. Remove the ifdef
+// here and use "= delete" always.
+#if defined(CHROMIUM_BUILD)
#define DISALLOW_COPY_AND_ASSIGN(TypeName) \
TypeName(const TypeName&) = delete; \
void operator=(const TypeName&) = delete
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698