Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2017543002: [Binding] [Refactoring] Make SerializedScriptValueWriter protected (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make most methods of SerializedScriptValueWriter protected. We still have a usage of takeWireString(), and it will be removed in another CL. BUG=614919 Committed: https://crrev.com/6b136d3aa98f994b1d540d4dc95fdc2b3daee005 Cr-Commit-Position: refs/heads/master@{#396681}

Patch Set 1 #

Patch Set 2 : Do not use isolate with empty context #

Patch Set 3 : Rebase #

Patch Set 4 : writeNull() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 2 3 4 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
peria
PTL
4 years, 7 months ago (2016-05-26 09:03:09 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-05-26 09:12:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017543002/1
4 years, 7 months ago (2016-05-26 09:13:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/77087)
4 years, 7 months ago (2016-05-26 10:15:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017543002/1
4 years, 7 months ago (2016-05-26 10:20:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/220148)
4 years, 7 months ago (2016-05-26 10:36:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017543002/1
4 years, 7 months ago (2016-05-26 10:37:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/154426)
4 years, 7 months ago (2016-05-26 10:42:03 UTC) #16
peria
PS1 was broken, because it uses an isolate with an empty context to create ScriptValueSerializer. ...
4 years, 7 months ago (2016-05-26 11:55:16 UTC) #17
peria
PTAL. SerializedScriptValueFactory still uses writer.takeWireString(), and removing it will be a bit complicated to do ...
4 years, 6 months ago (2016-05-30 04:02:04 UTC) #18
haraken
LGTM
4 years, 6 months ago (2016-05-30 04:03:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017543002/60001
4 years, 6 months ago (2016-05-30 04:03:52 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-30 05:40:41 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 05:41:36 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b136d3aa98f994b1d540d4dc95fdc2b3daee005
Cr-Commit-Position: refs/heads/master@{#396681}

Powered by Google App Engine
This is Rietveld 408576698