Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp

Issue 2017543002: [Binding] [Refactoring] Make SerializedScriptValueWriter protected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: writeNull() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
index 99bf89255dcd86f01be64d5ef246755fe0079678..407a22ef68be8b7ece01d5999ff5f6f737781d7e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
@@ -65,7 +65,7 @@ PassRefPtr<SerializedScriptValue> SerializedScriptValue::serialize(v8::Isolate*
PassRefPtr<SerializedScriptValue> SerializedScriptValue::serialize(const String& str)
{
- return SerializedScriptValueFactory::instance().create(str);
+ return create(ScriptValueSerializer::serializeWTFString(str));
}
PassRefPtr<SerializedScriptValue> SerializedScriptValue::serializeAndSwallowExceptions(v8::Isolate* isolate, v8::Local<v8::Value> value)
@@ -125,9 +125,7 @@ SerializedScriptValue::~SerializedScriptValue()
PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue()
{
- SerializedScriptValueWriter writer;
- writer.writeNull();
- return create(writer.takeWireString());
+ return create(ScriptValueSerializer::serializeNullValue());
}
// Convert serialized string to big endian wire data.

Powered by Google App Engine
This is Rietveld 408576698