Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2017393002: bluetooth: Rename device's GetName to GetNameForDisplay (Closed)

Created:
4 years, 6 months ago by scheib
Modified:
4 years, 6 months ago
Reviewers:
ortuno
CC:
achuith+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, hidehiko+watch_chromium.org, jam, kalyank, lhchavez+watch_chromium.org, ortuno+watch_chromium.org, oshima+watch_chromium.org, sadrul, scheib+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Rename device's GetName to GetNameForDisplay This change prepares for Web Bluetooth to filter by unnamed devices and avoid disclosing MAC addresses to web pages. It is desired for GetName to return the actual device name. To prepare for that this change renames the previous GetName behavior to GetNameForDisplay. http://crrev.com/2017393002 GetName -> GetNameForDisplay <<< This change. http://crrev.com/2009753002 New GetName http://crrev.com/2014473002 Web Bluetooth updated http://crrev.com/2020923002 Arc Bridge updated BUG=615720 TBR=jam For method rename refactor crossing many disparate owners. Committed: https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b Cr-Commit-Position: refs/heads/master@{#397500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -58 lines) Patch
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
scheib
4 years, 6 months ago (2016-06-01 21:52:18 UTC) #3
ortuno
lgtm
4 years, 6 months ago (2016-06-01 21:59:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017393002/1
4 years, 6 months ago (2016-06-01 22:06:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/193323)
4 years, 6 months ago (2016-06-01 22:23:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017393002/1
4 years, 6 months ago (2016-06-01 23:49:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239312)
4 years, 6 months ago (2016-06-02 02:10:34 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017393002/1
4 years, 6 months ago (2016-06-02 16:42:55 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 18:30:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017393002/1
4 years, 6 months ago (2016-06-02 20:36:07 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 20:43:02 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 20:44:40 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b
Cr-Commit-Position: refs/heads/master@{#397500}

Powered by Google App Engine
This is Rietveld 408576698