components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc - Issue 2017393002: bluetooth: Rename device's GetName to GetNameForDisplay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

Issue 2017393002: bluetooth: Rename device's GetName to GetNameForDisplay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/pairing/bluetooth_controller_pairing_controller.cc ('k') | content/browser/bluetooth/bluetooth_device_chooser_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

index 6691536882bf307e525d09ddfdb5814317b8e107..be22b1852b8531f3611b1ca5e15e250467d64a3a 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

+++ b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

@@ -257,7 +257,7 @@ TEST_F(ProximityAuthBluetoothLowEnergyConnectionFinderTest,

ExpectRemoveObserver();

PrepareDevice(kServiceUUID, kTestRemoteDeviceBluetoothAddress, false);

- ON_CALL(*device_, GetName())

+ ON_CALL(*device_, GetNameForDisplay())

.WillByDefault(Return(base::UTF8ToUTF16(kTestRemoteDeviceName)));

connection_finder.ExpectCreateConnection();

@@ -273,7 +273,7 @@ TEST_F(ProximityAuthBluetoothLowEnergyConnectionFinderTest,

ExpectRemoveObserver();

PrepareDevice(kOtherUUID, kTestRemoteDeviceBluetoothAddress, false);

- ON_CALL(*device_, GetName())

+ ON_CALL(*device_, GetNameForDisplay())

.WillByDefault(Return(base::UTF8ToUTF16("Other name")));

EXPECT_CALL(connection_finder, CreateConnectionProxy()).Times(0);