third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

index bffa584cba6dca4b3035d5966957d4203668315f..1eeb0c9e1ecf38e38ed3ead4c0067c24d50959b5 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

@@ -32,11 +32,11 @@

HTMLFormElement* populateForm(const char* enctype, const char* html)

{

StringBuilder b;

- b.append("<!DOCTYPE html><html><body><form id='theForm' enctype='");

+ b.appendLiteral("<!DOCTYPE html><html><body><form id='theForm' enctype='");

b.append(enctype);

- b.append("'>");

+ b.appendLiteral("'>");

b.append(html);

- b.append("</form></body></html>");

+ b.appendLiteral("</form></body></html>");

document().documentElement()->setInnerHTML(b.toString(), ASSERT_NO_EXCEPTION);

document().view()->updateAllLifecyclePhases();

HTMLFormElement* form = toHTMLFormElement(document().getElementById("theForm"));