third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

index ac5090f67148dcf585cda73421338ab3e1c9503d..89a55d1bd201d0bc2383fcf82c6ad1de932c879f 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

@@ -426,14 +426,14 @@

const FontDescription& fontDescription = state().font().getFontDescription();

if (fontDescription.style() == FontStyleItalic)

- serializedFont.append("italic ");

+ serializedFont.appendLiteral("italic ");

if (fontDescription.weight() == FontWeightBold)

- serializedFont.append("bold ");

+ serializedFont.appendLiteral("bold ");

if (fontDescription.variantCaps() == FontDescription::SmallCaps)

- serializedFont.append("small-caps ");

+ serializedFont.appendLiteral("small-caps ");

serializedFont.appendNumber(fontDescription.computedPixelSize());

- serializedFont.append("px");

+ serializedFont.appendLiteral("px");

const FontFamily& firstFontFamily = fontDescription.family();

for (const FontFamily* fontFamily = &firstFontFamily; fontFamily; fontFamily = fontFamily->next()) {