New chromium.perf.fyi battor bots. Win HP and DELL laptops.

New chromium.perf.fyi battor bots. Win HP and DELL laptops.

BUG=608429
Committed: https://chromium.googlesource.com/chromium/tools/build/+/dbb8cdcaaa8aaa6d243e9f6ef74e74415d0faa25

[aiolos (Not reviewing), 2016-05-27 18:51:21]

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:93: name='Win
Power Perf',
Is this right, or should I have a bot spec with matching name for each of the
bots?

[fmeawad, 2016-05-27 18:53:47]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-05-27 18:53:48]

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:93: name='Win
Power Perf',
On 2016/05/27 18:51:21, aiolos wrote:
> Is this right, or should I have a bot spec with matching name for each of the
> bots?

It is a bot spec per configuration, and you have 2 configurations here, so you
should have one for HP and one for Dell

[aiolos (Not reviewing), 2016-05-27 18:59:47]

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2017163002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:93: name='Win
Power Perf',
On 2016/05/27 18:53:48, fmeawad wrote:
> On 2016/05/27 18:51:21, aiolos wrote:
> > Is this right, or should I have a bot spec with matching name for each of
the
> > bots?
> 
> It is a bot spec per configuration, and you have 2 configurations here, so you
> should have one for HP and one for Dell

Done.

[fmeawad, 2016-05-27 19:08:49]

lgtm

[fmeawad, 2016-05-27 19:10:10]

On 2016/05/27 19:08:49, fmeawad wrote:
> lgtm

You will need to request a master.chromium.perf.fyi restart for the changes to
take effect.

[fmeawad, 2016-05-27 19:39:40]

lgtm

https://codereview.chromium.org/2017163002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2017163002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:104:
perf_id='win-power-fyi',
You need a unique perf ID for each.
win-power-fyi-dell

[aiolos (Not reviewing), 2016-05-27 19:43:51]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2016-05-27 19:43:52]

The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2017163002/#ps80001
(title: "Actually fix bot spec.")

[commit-bot: I haz the power, 2016-05-27 19:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017163002/80001

[commit-bot: I haz the power, 2016-05-27 19:47:37]

Description was changed from

==========
New chromium.perf.fyi battor bots. Win HP and DELL laptops.

BUG=608429
==========

to

==========
New chromium.perf.fyi battor bots. Win HP and DELL laptops.

BUG=608429

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/dbb8cdcaaa8aaa6d243e...
==========

[commit-bot: I haz the power, 2016-05-27 19:47:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/build/+/dbb8cdcaaa8aaa6d243e...