scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py - Issue 2017163002: New chromium.perf.fyi battor bots. Win HP and DELL laptops.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

Issue 2017163002: New chromium.perf.fyi battor bots. Win HP and DELL laptops. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Remove 7 from bot spec name. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « masters/master.chromium.perf.fyi/slaves.cfg ('k') | scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from . import steps	5 from . import steps

6	6

7	7

8 RESULTS_URL = 'https://chromeperf.appspot.com'	8 RESULTS_URL = 'https://chromeperf.appspot.com'

9	9

10	10

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83	83

84 _AddBotSpec(	84 _AddBotSpec(

85 name='Win 7 Intel GPU Perf (Xeon)',	85 name='Win 7 Intel GPU Perf (Xeon)',

86 platform='win',	86 platform='win',

87 parent_builder='Win x64 Builder',	87 parent_builder='Win x64 Builder',

88 perf_id='chromium-rel-win7-gpu-intel',	88 perf_id='chromium-rel-win7-gpu-intel',

89 target_bits=64,	89 target_bits=64,

90 parent_master='chromium.perf')	90 parent_master='chromium.perf')

91	91

92 _AddBotSpec(	92 _AddBotSpec(

	93 name='Win Power Perf',
	aiolos (Not reviewing) 2016/05/27 18:51:21 Is this right, or should I have a bot spec with ma Is this right, or should I have a bot spec with matching name for each of the bots? fmeawad 2016/05/27 18:53:48 It is a bot spec per configuration, and you have 2 Show quoted text On 2016/05/27 18:51:21, aiolos wrote: > Is this right, or should I have a bot spec with matching name for each of the > bots? It is a bot spec per configuration, and you have 2 configurations here, so you should have one for HP and one for Dell aiolos (Not reviewing) 2016/05/27 18:59:46 Done. Show quoted text On 2016/05/27 18:53:48, fmeawad wrote: > On 2016/05/27 18:51:21, aiolos wrote: > > Is this right, or should I have a bot spec with matching name for each of the > > bots? > > It is a bot spec per configuration, and you have 2 configurations here, so you > should have one for HP and one for Dell Done.
	94 platform='win',

	95 parent_builder='Win x64 Builder',

	96 perf_id='win-power-fyi',

	97 target_bits=64,

	98 parent_master='chromium.perf')

	99

	100 _AddBotSpec(

93 name='Win Clang Perf',	101 name='Win Clang Perf',

94 platform='win',	102 platform='win',

95 parent_builder='Win Clang Builder',	103 parent_builder='Win Clang Builder',

96 perf_id='chromium-win-clang',	104 perf_id='chromium-win-clang',

97 target_bits=32)	105 target_bits=32)

OLD	NEW