Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2017093004: Revert "Make test.dart override only those dependencies declared in the pubspec.yaml" (Closed)

Created:
4 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make test.dart override only those dependencies declared in the pubspec.yaml" This reverts commit bcfdd3345b141a42f06cccac129350cdf16f53ff. Broke standalone/io/test_runner_test, need to investigate. BUG= Committed: https://github.com/dart-lang/sdk/commit/dd7cfb2b62c38554124597ea89af80861a97b6a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -38 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/pkgbuild.status View 1 chunk +1 line, -0 lines 0 comments Download
D tools/.packages View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +1 line, -25 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as dd7cfb2b62c38554124597ea89af80861a97b6a9 (presubmit successful).
4 years, 6 months ago (2016-05-28 00:39:26 UTC) #2
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-05-28 00:43:13 UTC) #4
Message was sent while issue was closed.
TBR

Reverting. Two issues:
- broke a vm standalone test
- I excluded some DEPS that I should have kept

(I had added a few new DEPS before trying this idea, when I tried this idea I
reverted the changes in the DEPS, but I didn't delete my third_party/pkg/
folder, so I had some stale data and tests passed locally).

Powered by Google App Engine
This is Rietveld 408576698