Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2016943003: scheduler: Avoid false alerts about expensive task blocking (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Avoid false alerts about expensive task blocking This patch adjusts the logic for logging a console message when an expensive task is blocked: 1. Don't log messages when all timer tasks are blocked (e.g., while waiting for a touchstart response). There's nothing the developer can do to avoid this type of blocking. 2. Only report blocking for tasks which exceed the 50ms RAIL threshold. These types of tasks are most likely to cause user visible jank. Lower blocking thresholds are also used for shorter periods of time, so shorter tasks are not likely to be deferred for a long time in any case. 3. Also mention network tasks in the log message. BUG=613230 Committed: https://crrev.com/c66723959e9a37f1a5bbd821366a2ee24a9537c2 Cr-Commit-Position: refs/heads/master@{#396467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M components/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sami
PTAL.
4 years, 6 months ago (2016-05-27 12:46:29 UTC) #3
Sami
PTAL.
4 years, 6 months ago (2016-05-27 12:46:29 UTC) #4
alex clarke (OOO till 29th)
lgtm
4 years, 6 months ago (2016-05-27 12:54:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016943003/1
4 years, 6 months ago (2016-05-27 13:27:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 14:50:59 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 14:53:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c66723959e9a37f1a5bbd821366a2ee24a9537c2
Cr-Commit-Position: refs/heads/master@{#396467}

Powered by Google App Engine
This is Rietveld 408576698