Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2016943003: scheduler: Avoid false alerts about expensive task blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index de5aefc410e553aea4079ce8b0f45abfa77832aa..7b6d24cab5870fd9405f44d5acd277868cf618e5 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2877,6 +2877,54 @@ TEST_F(RendererSchedulerImplTest, BlockedTimerNotification_TimersSuspended) {
EXPECT_EQ(0u, web_view_scheduler.console_warnings().size());
}
+TEST_F(RendererSchedulerImplTest, BlockedTimerNotification_TOUCHSTART) {
+ // Make sure we don't report warnings about blocked tasks during TOUCHSTART.
+ WebViewSchedulerImplForTest web_view_scheduler(scheduler_.get());
+
+ scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
+ DoMainFrame();
+ SimulateExpensiveTasks(timer_task_runner_);
+ SimulateCompositorGestureStart(TouchEventPolicy::SEND_TOUCH_START);
+ scheduler_->DidHandleInputEventOnCompositorThread(
+ FakeInputEvent(blink::WebInputEvent::TouchStart),
+ RendererScheduler::InputEventState::EVENT_CONSUMED_BY_COMPOSITOR);
+ EXPECT_EQ(UseCase::TOUCHSTART, ForceUpdatePolicyAndGetCurrentUseCase());
+
+ std::vector<std::string> run_order;
+ PostTestTasks(&run_order, "T1 T2");
+ RunUntilIdle();
+
+ EXPECT_EQ(0u, run_order.size());
+ EXPECT_EQ(0u, web_view_scheduler.console_warnings().size());
+}
+
+TEST_F(RendererSchedulerImplTest,
+ BlockedTimerNotification_SYNCHRONIZED_GESTURE) {
+ // Make sure we only report warnings during a high blocking threshold.
+ WebViewSchedulerImplForTest web_view_scheduler(scheduler_.get());
+
+ scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
+ DoMainFrame();
+ SimulateExpensiveTasks(timer_task_runner_);
+ SimulateCompositorGestureStart(TouchEventPolicy::DONT_SEND_TOUCH_START);
+
+ cc::BeginFrameArgs begin_frame_args = cc::BeginFrameArgs::Create(
+ BEGINFRAME_FROM_HERE, clock_->NowTicks(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(16), cc::BeginFrameArgs::NORMAL);
+ begin_frame_args.on_critical_path = true;
+ scheduler_->WillBeginFrame(begin_frame_args);
+
+ EXPECT_EQ(UseCase::SYNCHRONIZED_GESTURE,
+ ForceUpdatePolicyAndGetCurrentUseCase());
+
+ std::vector<std::string> run_order;
+ PostTestTasks(&run_order, "T1 T2");
+ RunUntilIdle();
+
+ EXPECT_EQ(0u, run_order.size());
+ EXPECT_EQ(0u, web_view_scheduler.console_warnings().size());
+}
+
namespace {
void SlowCountingTask(size_t* count,
base::SimpleTestTickClock* clock,
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698