Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2016893002: [Material][Mac] Remove the colon in the selected keyword decoration (Closed)

Created:
4 years, 6 months ago by spqchan
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Remove the colon in the selected keyword decoration BUG=615251 Committed: https://crrev.com/dc97fcbf3accecbb6898dca34586c1be33dea7f5 Cr-Commit-Position: refs/heads/master@{#396565}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix for shrike #

Patch Set 3 : fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm View 1 2 1 chunk +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
spqchan
PTAL
4 years, 6 months ago (2016-05-26 21:15:47 UTC) #2
shrike
LGTM. Do you want to give it its own separate bug? If not, we have ...
4 years, 6 months ago (2016-05-26 23:00:59 UTC) #3
spqchan
Created and updated the new bug https://codereview.chromium.org/2016893002/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm (left): https://codereview.chromium.org/2016893002/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm#oldcode73 chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm:73: // The text ...
4 years, 6 months ago (2016-05-27 00:29:51 UTC) #5
Avi (use Gerrit)
lgtm
4 years, 6 months ago (2016-05-27 01:52:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016893002/20001
4 years, 6 months ago (2016-05-27 17:01:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/118567)
4 years, 6 months ago (2016-05-27 17:54:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016893002/40001
4 years, 6 months ago (2016-05-27 19:35:06 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-27 21:26:15 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:27:43 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc97fcbf3accecbb6898dca34586c1be33dea7f5
Cr-Commit-Position: refs/heads/master@{#396565}

Powered by Google App Engine
This is Rietveld 408576698