chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm - Issue 2016893002: [Material][Mac] Remove the colon in the selected keyword decoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm

Issue 2016893002: [Material][Mac] Remove the colon in the selected keyword decoration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm b/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm

index 4dee6de9f954b9db6bede297a0021dd03d202513..a8a1ae8480ff0ac949ca49cc823b9bd4a17060b9 100644

--- a/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm

+++ b/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm

@@ -47,8 +47,13 @@ class SelectedKeywordDecorationTest : public CocoaTest {

TEST_F(SelectedKeywordDecorationTest, UsesPartialKeywordIfNarrow) {

const base::string16 kKeyword = base::ASCIIToUTF16("Engine");

- NSString* const kFullString = @"Search Engine:";

- NSString* const kPartialString = @"Search En\u2026:"; // ellipses

+ NSString* const kFullString = ui::MaterialDesignController::IsModeMaterial()

+ ? @"Search Engine"

+ : @"Search Engine:";

+ NSString* const kPartialString =

+ ui::MaterialDesignController::IsModeMaterial()

+ ? @"Search En\u2026"

+ : @"Search En\u2026:"; // ellipses

decoration_.SetKeyword(kKeyword, false);