Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 2016863002: Log BIDIRECTIONL_STREAM_ALIVE before HTTP_STREAM_REQUEST (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/bidirectional_stream.cc ('K') | « net/http/bidirectional_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream_unittest.cc
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 9fa41cf62a693e7c8fefe236761cbe22cf2461eb..4809dd6c09772d31ad73bf45e55d670194a33e8a 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -580,7 +580,12 @@ TEST_F(BidirectionalStreamTest, TestNetLogContainEntries) {
net_log_.GetEntries(&entries);
size_t index = ExpectLogContainsSomewhere(
entries, 0, NetLog::TYPE_BIDIRECTIONAL_STREAM_ALIVE, NetLog::PHASE_BEGIN);
- // Headers received should happen after BIDIRECTIONAL_STREAM_ALIVE.
+ // HTTP_STREAM_REQUEST is nested inside in BIDIRECTIONAL_STREAM_ALIVE.
+ index = ExpectLogContainsSomewhere(
+ entries, index, NetLog::TYPE_HTTP_STREAM_REQUEST, NetLog::PHASE_BEGIN);
+ index = ExpectLogContainsSomewhere(
+ entries, index, NetLog::TYPE_HTTP_STREAM_REQUEST, NetLog::PHASE_END);
+ // Headers received should happen after HTTP_STREAM_REQUEST.
index = ExpectLogContainsSomewhere(
entries, index, NetLog::TYPE_BIDIRECTIONAL_STREAM_RECV_HEADERS,
NetLog::PHASE_NONE);
« net/http/bidirectional_stream.cc ('K') | « net/http/bidirectional_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698