Log BIDIRECTIONL_STREAM_ALIVE before HTTP_STREAM_REQUEST

net/http/bidirectional_stream.cc

Index: net/http/bidirectional_stream.cc
diff --git a/net/http/bidirectional_stream.cc b/net/http/bidirectional_stream.cc
index 8b83c1e93515f06efaa4db3b5aaca903b35ec1ca..5d5b7f9b20abc0fb91d5204aab10f7e75889150f 100644
--- a/net/http/bidirectional_stream.cc
+++ b/net/http/bidirectional_stream.cc
@@ -90,6 +90,13 @@ BidirectionalStream::BidirectionalStream(
   DCHECK(delegate_);
   DCHECK(request_info_);
 
+  if (net_log_.IsCapturing()) {

[mef, 2016/06/01 17:25:40]

Should this go down below the failure exit if not Https? Also, do we need a test
for that?

[xunjieli, 2016/06/01 17:38:45]

I think it should be before the failure exit. In case we have the disallowed
schemes, we have logs for it too. When we enter the failure exit, we still
create the BidirectionalStream object, so I think it makes sense to log the
event.

We do have a test for the early exit. It is in
BidirectionalStreamTest.CreateInsecureStream.

[mef, 2016/06/01 17:45:33]

sgtm, thanks for explanation!

[xunjieli, 2016/06/01 22:23:28]

thanks for the review!

+    net_log_.BeginEvent(
+        NetLog::TYPE_BIDIRECTIONAL_STREAM_ALIVE,
+        base::Bind(&NetLogCallback, &request_info_->url, &request_info_->method,
+                   base::Unretained(&request_info_->extra_headers)));
+  }
+
   SSLConfig server_ssl_config;
   session->ssl_config_service()->GetSSLConfig(&server_ssl_config);
   session->GetAlpnProtos(&server_ssl_config.alpn_protos);
@@ -116,12 +123,6 @@ BidirectionalStream::BidirectionalStream(
   // Check that HttpStreamFactory does not invoke OnBidirectionalStreamImplReady
   // synchronously.
   DCHECK(!stream_impl_);
-  if (net_log_.IsCapturing()) {
-    net_log_.BeginEvent(
-        NetLog::TYPE_BIDIRECTIONAL_STREAM_ALIVE,
-        base::Bind(&NetLogCallback, &request_info_->url, &request_info_->method,
-                   base::Unretained(&request_info_->extra_headers)));
-  }
 }
 
 BidirectionalStream::~BidirectionalStream() {