Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2016783002: Fix a crash when download a DRM file through context menu (Closed)

Created:
4 years, 7 months ago by qinmin
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix a crash when download a DRM file through context menu This is a regression introduced by https://codereview.chromium.org/1717783002. Previously we use URLUtil.guessFileName() to generate file names for download. However, to fix crbug/570750, we rely on the native code to pass the file name. However, drm download through context menu bypasses the native download code. As a result, we need to generate the file name in Java if it is null. Since content disposition is null, this will not cause the same problem as reported in crbug/570750. TBR=tedchoc@chromium.org BUG=608258 Review-Url: https://codereview.chromium.org/2013643002 Cr-Commit-Position: refs/heads/master@{#395750} (cherry picked from commit 4e33c5d6978752f31ed6702e72e46fdf78cd5565) Committed: https://chromium.googlesource.com/chromium/src/+/421b2fbe002d915307cc547e86b6004bba0bf4a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 7 months ago (2016-05-26 18:39:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
421b2fbe002d915307cc547e86b6004bba0bf4a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698