Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2013643002: Fix a crash when download a DRM file through context menu (Closed)

Created:
4 years, 7 months ago by qinmin
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when download a DRM file through context menu This is a regression introduced by https://codereview.chromium.org/1717783002. Previously we use URLUtil.guessFileName() to generate file names for download. However, to fix crbug/570750, we rely on the native code to pass the file name. However, drm download through context menu bypasses the native download code. As a result, we need to generate the file name in Java if it is null. Since content disposition is null, this will not cause the same problem as reported in crbug/570750. BUG=608258 Committed: https://crrev.com/4e33c5d6978752f31ed6702e72e46fdf78cd5565 Cr-Commit-Position: refs/heads/master@{#395750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 7 months ago (2016-05-24 22:26:26 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-24 22:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013643002/1
4 years, 7 months ago (2016-05-24 22:57:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 00:29:02 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:30:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e33c5d6978752f31ed6702e72e46fdf78cd5565
Cr-Commit-Position: refs/heads/master@{#395750}

Powered by Google App Engine
This is Rietveld 408576698